From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 855C028C2AF for ; Mon, 30 Jun 2025 14:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751294176; cv=none; b=Q7Fpem3BWZ7NTgNlfuZ7bsvqstJPfTFW0J2Xczo8d4LeVPSHanMChgXvSnfLR6p7p5Zj3jZLCqay5WVRX6d8kp3b2moT2PuKNwHRjw5HqM0q3zvMPxEpa+JcjULuIuDj1GzoyRXGOnwGfXmIKRCVrA9OAsnmL8BbbkpQLeiwRsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751294176; c=relaxed/simple; bh=iJ7bqgXfPtMBXmUDY/YhJ+N8O2D9Z1dGk3Blw7bpjMI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O5qaefPXZ4fXSKcaxhZelEHHWYXcty8rBG/ptmd0+Pb/4rqwf5mSEazBRvqv+ouusT9NFv1UObE4Kw5J5x7/tt2SdouNxLxAnK2W3B2P/3eiN63UJXlnyExaJ1IUm1vImDmdWUnHTc68tSDO8A1OWif45xkmrhyWK6ITy18fIDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dDeqjcsE; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dDeqjcsE" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a50956e5d3so3886788f8f.1 for ; Mon, 30 Jun 2025 07:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1751294172; x=1751898972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NmutXua1lSKxORl0w3oIEp2FOLuV8/Za8RV+I5tfNXw=; b=dDeqjcsEoTAmg0IuTWbaXRAn1R6cYoIF0wgSIJTPmR/pdJWxOxJfaPJGVpaiEE8vkb mjycFblwzxfOi4MNggsUz9W5AzoVIdan2A0Ze64WIPBU7dS450G1/7X1NZItsl2npyAc UUh1rt5pVqM64qCid+fm25rXv4TMLfhb9ANEJE/jmBu9XzMbh0yIi5JEW17QMEbuLqUk I0g+lnuoh1xHmPRhR4rL1c5C6NFzRJxd6xboq4oUqukZruN+x5gE6HYp1ol0wxTwxD9C d3YbKkbtDgvcr/mQSJ9SaN5JAEl8/cr72LtEmo7CR+opSQeqnY0ZLCN61mYtzq15DDyy xa7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751294172; x=1751898972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NmutXua1lSKxORl0w3oIEp2FOLuV8/Za8RV+I5tfNXw=; b=ajZQDJjXYZVRMBtQ35agsqK6QnmMOHAB8LlZ9t4qbYizid4tpFf689egGr5YLsonr2 towXrVAnAApGpHz1bLmqTl7nTK0zAw9eBvYMWtiIwIm63QOZFaGiqxjygOCGa28k435B NR55DJfCU4Px/r8XceCcHRchdvKVTK3rPDjNWEczl+FXSnwaalQUsTqrbEg579U2SdDi tWwpHm2Uq/QoJAce+I0MvIRqywPCWqNCsrr7eyCgwAMQhKz19sJqydHOxtJi+MENA5V2 WqE4IozyUsbzaqsVOTJhm36+1jV88SM2fvXqHjVvz4XSUy5Wae46Ncl25WyFtIw6BOeI RcZw== X-Gm-Message-State: AOJu0Yws92gunp08czlJfrwaPzZCfpjvvEdHOEfzRMlfud4oagd6WxIq /djL559Ot/8Me4Q+ayS/Vytg5YsJWP9LEE1OPFbjMlpbXQNkCz+wZc0J3PYtHP6pRw0= X-Gm-Gg: ASbGncu4cesvX9DhI0UCP7tSTl3ARdeJ/wuPPtaAELQ5AqNWDCyik+nhCyBzJast0C/ 2vPP6hxrLQKiRRkDnycDwHgObZigDrLGXwXzfEY+Cb1ZrTlBdDcx6Ql7n0M8rF/+Qkj2Sl83YR1 ERzgg8ObOYt7Q3a5E+kHaQMI8H5DJIKUEU8+9wacjKazDBmS+RZ2W5/AwKYNWMs6jcFkf2ttYng NfjAqyLHwbU4aESOyoBggwSLk2LAKN9VDBLbfOgHbaLBuY+yiros7kXkvJm6xbGOa6Xk1kQSr8u 7iy4AcwfQu355KM2dJ5w1snNB5tktExXYxb0bG+Q+ETzaHsatxAwI5dkns/SKQ== X-Google-Smtp-Source: AGHT+IFeTwmcYHOYYLMQoffaVlLFKMuHfFzsJq4UbYAwtBydXgF3vYE5RuiejytIxEYKIFATVTkqYg== X-Received: by 2002:a5d:46c2:0:b0:3a5:2fae:1348 with SMTP id ffacd0b85a97d-3a918281259mr9014396f8f.51.1751294171768; Mon, 30 Jun 2025 07:36:11 -0700 (PDT) Received: from zovi.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a4064b1sm139691695e9.29.2025.06.30.07.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 07:36:11 -0700 (PDT) From: Petr Pavlu To: Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] module: Prevent silent truncation of module name in delete_module(2) Date: Mon, 30 Jun 2025 16:32:32 +0200 Message-ID: <20250630143535.267745-2-petr.pavlu@suse.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630143535.267745-1-petr.pavlu@suse.com> References: <20250630143535.267745-1-petr.pavlu@suse.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Passing a module name longer than MODULE_NAME_LEN to the delete_module syscall results in its silent truncation. This really isn't much of a problem in practice, but it could theoretically lead to the removal of an incorrect module. It is more sensible to return ENAMETOOLONG or ENOENT in such a case. Update the syscall to return ENOENT, as documented in the delete_module(2) man page to mean "No module by that name exists." This is appropriate because a module with a name longer than MODULE_NAME_LEN cannot be loaded in the first place. Signed-off-by: Petr Pavlu --- kernel/module/main.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index 413ac6ea3702..933a9854cb7d 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -751,14 +751,16 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user, struct module *mod; char name[MODULE_NAME_LEN]; char buf[MODULE_FLAGS_BUF_SIZE]; - int ret, forced = 0; + int ret, len, forced = 0; if (!capable(CAP_SYS_MODULE) || modules_disabled) return -EPERM; - if (strncpy_from_user(name, name_user, MODULE_NAME_LEN-1) < 0) - return -EFAULT; - name[MODULE_NAME_LEN-1] = '\0'; + len = strncpy_from_user(name, name_user, MODULE_NAME_LEN); + if (len == 0 || len == MODULE_NAME_LEN) + return -ENOENT; + if (len < 0) + return len; audit_log_kern_module(name); -- 2.49.0