From: Sami Tolvanen <samitolvanen@google.com>
To: Giuliano Procida <gprocida@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] gendwarfksyms: use preferred form of sizeof for allocation
Date: Tue, 1 Jul 2025 17:06:47 +0000 [thread overview]
Message-ID: <20250701170647.GA2234472@google.com> (raw)
In-Reply-To: <20250701152000.2477659-2-gprocida@google.com>
On Tue, Jul 01, 2025 at 04:19:10PM +0100, Giuliano Procida wrote:
> The preferred form is to use the variable being allocated to, rather
> than explicitly supplying a type name which might become stale.
>
> Also do this for memset.
>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Sami
next prev parent reply other threads:[~2025-07-01 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAK7LNASzE1CtRo9T4byPXJtB-HtuWsGe=OLba+8JU9fB28Chow@mail.gmail.com>
2025-07-01 15:19 ` [PATCH v2 0/2] gendwarfksyms - improve symtypes output Giuliano Procida
2025-07-01 15:19 ` [PATCH v2 1/2] gendwarfksyms: use preferred form of sizeof for allocation Giuliano Procida
2025-07-01 17:06 ` Sami Tolvanen [this message]
2025-07-01 15:19 ` [PATCH v2 2/2] gendwarfksyms: order -T symtypes output by name Giuliano Procida
2025-07-02 2:30 ` [PATCH v2 0/2] gendwarfksyms - improve symtypes output Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701170647.GA2234472@google.com \
--to=samitolvanen@google.com \
--cc=gprocida@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).