linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: "Kees Cook" <kees@kernel.org>,
	"Hans Verkuil" <hverkuil+cisco@kernel.org>,
	"Malcolm Priestley" <tvboxspy@gmail.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	linux-media@vger.kernel.org, "Hans Verkuil" <hverkuil@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Rusty Russell" <rusty@rustcorp.com.au>,
	"Petr Pavlu" <petr.pavlu@suse.com>,
	"Daniel Gomez" <da.gomez@kernel.org>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH v2 1/3] media: dvb-usb-v2: lmedm04: Fix firmware macro definitions
Date: Thu,  9 Oct 2025 20:06:07 -0700	[thread overview]
Message-ID: <20251010030610.3032147-1-kees@kernel.org> (raw)
In-Reply-To: <20251010030348.it.784-kees@kernel.org>

The firmware filename macros incorrectly included semicolons in their
string literal definitions. Right now, this wasn't causing any real
problem, but coming changes to the MODULE_INFO() macro make this more
sensitive. Specifically, when used with MODULE_FIRMWARE(), this
created syntax errors during macro expansion:

    MODULE_FIRMWARE(LME2510_C_S7395);

expands to:

    MODULE_INFO(firmware, "dvb-usb-lme2510c-s7395.fw";)
                                                     ^
                                          syntax error

Remove the trailing semicolons from all six firmware filename macro
definitions. Semicolons should only appear at the point of use, not in
the macro definition.

Reviewed-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Kees Cook <kees@kernel.org>
---
Cc: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>
---
 drivers/media/usb/dvb-usb-v2/lmedm04.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c
index 0c510035805b..05c18b6de5c6 100644
--- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
+++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
@@ -70,12 +70,12 @@
 #include "ts2020.h"
 
 
-#define LME2510_C_S7395	"dvb-usb-lme2510c-s7395.fw";
-#define LME2510_C_LG	"dvb-usb-lme2510c-lg.fw";
-#define LME2510_C_S0194	"dvb-usb-lme2510c-s0194.fw";
-#define LME2510_C_RS2000 "dvb-usb-lme2510c-rs2000.fw";
-#define LME2510_LG	"dvb-usb-lme2510-lg.fw";
-#define LME2510_S0194	"dvb-usb-lme2510-s0194.fw";
+#define LME2510_C_S7395	"dvb-usb-lme2510c-s7395.fw"
+#define LME2510_C_LG	"dvb-usb-lme2510c-lg.fw"
+#define LME2510_C_S0194	"dvb-usb-lme2510c-s0194.fw"
+#define LME2510_C_RS2000 "dvb-usb-lme2510c-rs2000.fw"
+#define LME2510_LG	"dvb-usb-lme2510-lg.fw"
+#define LME2510_S0194	"dvb-usb-lme2510-s0194.fw"
 
 /* debug */
 static int dvb_usb_lme2510_debug;
-- 
2.34.1


  reply	other threads:[~2025-10-10  3:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-10  3:06 [PATCH v2 0/3] module: Add compile-time check for embedded NUL characters Kees Cook
2025-10-10  3:06 ` Kees Cook [this message]
2025-10-10  7:10   ` [PATCH v2 1/3] media: dvb-usb-v2: lmedm04: Fix firmware macro definitions Mauro Carvalho Chehab
2025-10-10  3:06 ` [PATCH v2 2/3] media: radio: si470x: Fix DRIVER_AUTHOR macro definition Kees Cook
2025-10-10  7:10   ` Mauro Carvalho Chehab
2025-10-10  3:06 ` [PATCH v2 3/3] module: Add compile-time check for embedded NUL characters Kees Cook
2025-10-10  4:19   ` Petr Pavlu
2025-10-21  2:05   ` Aaron Tomlin
2025-11-03  8:54   ` Hans Verkuil
2025-11-03  8:58     ` Daniel Gomez
2025-11-03  9:05       ` Hans Verkuil
2025-11-03 19:49 ` [PATCH v2 0/3] " Daniel Gomez
2025-11-04  0:13   ` Kees Cook
2025-11-04  6:35     ` Daniel Gomez
2025-11-04 10:35       ` Hans Verkuil
2025-11-04 12:03         ` Daniel Gomez
2025-11-04 20:35           ` Daniel Gomez
2025-11-04 20:59             ` Hans Verkuil
2025-11-05 13:03 ` Daniel Gomez
2025-11-05 13:06   ` Daniel Gomez
2025-11-11 11:42   ` Andy Shevchenko
2025-11-11 12:34     ` Daniel Gomez
2025-11-11 17:52     ` Uwe Kleine-König
2025-11-05 13:19 ` Daniel Gomez
     [not found] ` <68ed624c.050a0220.3ba739.64ea@mx.google.com>
     [not found]   ` <D1CBCBE2-3A54-410A-B15C-F1C621F9F56B@kernel.org>
     [not found]     ` <CANiDSCu6xZAuSF5_M-4BMRc52hbSh_1QfDQqaeGR4iD5fdQjQg@mail.gmail.com>
     [not found]       ` <202510141344.E0ABCD2C7@keescook>
     [not found]         ` <CANiDSCsBAq3Yx4ybarUb_1NkQ-bvfXvWqb-DfqXatkiYJFZWiQ@mail.gmail.com>
     [not found]           ` <202510201127.D97BCF2@keescook>
     [not found]             ` <CANiDSCtbrM4Fg_p56EdV09ts_j8HnMCc1hGH31-BZvv03Z0DjQ@mail.gmail.com>
     [not found]               ` <202510201146.F12EA92@keescook>
2025-11-11 13:14                 ` [v2,0/3] " Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251010030610.3032147-1-kees@kernel.org \
    --to=kees@kernel.org \
    --cc=da.gomez@kernel.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=hverkuil@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rusty@rustcorp.com.au \
    --cc=samitolvanen@google.com \
    --cc=tvboxspy@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).