From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com [185.226.149.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7B602E2667; Sun, 30 Nov 2025 23:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.226.149.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764544198; cv=none; b=n5jUlHZ1KjB+sKxptCf7imEJiD1ZpxOZBVmXuxM5N0o3ANqPL5+mnKIRZqVbIUTtv0lfEc4fzxLyXpu4NQErQqdtBOKh6WCeoyDQXmJGC9SA/kxZT2c9oy78WXts1bWfXSPj0atItTjtCxkeSHbPFCAdAWtvrK9+y+Iw7PZzaiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764544198; c=relaxed/simple; bh=1TxIg6DR6kFhh7BhfJjY+w1v/VDcS93iexd02QJiYMk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C4moCZJ32irVX6LWlz/pRpMJUSMvoanDtdDLxfZXlX9nMgBd3pspSCmdhGfe8v6BBlrTJSif6OJvpXsMSQq2WEs638RmA/h5l17zEyPUu4uJev0LJAx6S/bQVyQ9wKF/5jbllRKAs/s92REEBarvst7KLaSv82mWxwfRUQt9nls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=runbox.com; spf=pass smtp.mailfrom=runbox.com; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b=mFrPq+wX; arc=none smtp.client-ip=185.226.149.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=runbox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=runbox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b="mFrPq+wX" Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1vPqXs-0067c4-Is; Mon, 01 Dec 2025 00:09:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=v/S2j3lvoVofj+NHzuY+rgCTCXBDYm4Z6flk9aF4pmQ=; b=mFrPq+wXEaIoygFF9DHa4zLG3L TyqZ63LxHSpAHU/YMdp+Q6uRww/6Rro4MG75ng3EP2g/2YovW2KntIhIfi6G+JO/52OnzRNGqa7R4 2SGYb/AId7BQUF6qt3rY/Z1R4rEYxdA/lfkROXhLh0cAAXh1gv8NdJYHRa/M1dKg9knqdqylfsUKK 1UiT4/cfp+81OXx7n/5+RZXW+sbnCLVNIuakvoXf+/9BBeh7qp7A+idVLbLeGdK0mYrA1i8qoSSWK kb0nyGd7g06G/zQIELdQiSRl88kvzkKM4fsfuBjNIjJbLBEtvZG6+QFQBwDi8vdLE3pNIG0mqEoYw KEGKE1OA==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1vPqXq-0007xb-5s; Mon, 01 Dec 2025 00:09:30 +0100 Received: by submission01.runbox with esmtpsa [Authenticated ID (1493616)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1vPqXo-0065vo-KU; Mon, 01 Dec 2025 00:09:28 +0100 Date: Sun, 30 Nov 2025 23:09:25 +0000 From: david laight To: Andy Shevchenko Cc: Yury Norov , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Petr Pavlu , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] tracing: move tracing declarations from kernel.h to a dedicated header Message-ID: <20251130230925.376b5377@pumpkin> In-Reply-To: References: <20251129195304.204082-1-yury.norov@gmail.com> <20251129195304.204082-4-yury.norov@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 30 Nov 2025 21:44:46 +0200 Andy Shevchenko wrote: > On Sun, Nov 30, 2025 at 01:16:19PM -0500, Yury Norov wrote: > > On Sat, Nov 29, 2025 at 10:30:23PM +0200, Andy Shevchenko wrote: > > > On Sat, Nov 29, 2025 at 02:53:02PM -0500, Yury Norov (NVIDIA) wrote: > > > > Tracing is a half of the kernel.h in terms of LOCs, although it's a > > > > self-consistent part. Move it to a separate header. > > > > > > > > This is a pure move, except for removing a few 'extern's. > > > > > > Yeah, I also have something similar (but half-baked) locally, the Q I wanted to > > > ask is why a separate header? We have already some of tracing headers. Doesn't > > > suit well? > > > > Just as said in the commit message - this part is more or less > > self-consistent and debugging-oriented. If someone needs to just > > throw trace_printk() in their driver, they will not have to pull > > all the heavy tracing machinery. > > Please, add a summary of this to it. It will be much clearer and based on it > I agree with your judgement. It is worth checking whether the files get included anyway, and whether it really makes that much difference. Fiddling with kernel.h and extracting small 'leaf' headers from it is also unlikely to make a big difference. Try adding a syntax error to (say) sys/ioctl.h and see where it is included from the first time - I suspect you'll be surprised. Working on that include list might be more fruitful (in reducing build times). David