From: Eric Biggers <ebiggers@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
Stephan Mueller <smueller@chronox.de>,
Lukas Wunner <lukas@wunner.de>,
Ignat Korchagin <ignat@cloudflare.com>,
keyrings@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] lib/crypto: tests: Add KUnit tests for ML-DSA verification
Date: Wed, 3 Dec 2025 09:43:03 -0800 [thread overview]
Message-ID: <20251203174303.GA1417@sol> (raw)
In-Reply-To: <1682768.1764752475@warthog.procyon.org.uk>
On Wed, Dec 03, 2025 at 09:01:15AM +0000, David Howells wrote:
> I'm seeing:
>
> ERROR: modpost: module mldsa_kunit uses symbol mldsa_use_hint from namespace EXPORTED_FOR_KUNIT_TESTING, but does not import it.
>
Yep, sorry for the trouble. mldsa_kunit.c needs:
MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING");
Would be nice if the kunit_test_suite() macro did that so that test
authors don't have to remember to add the namespace import separately.
But maybe there's a reason why they need to be separate.
- Eric
next prev parent reply other threads:[~2025-12-03 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 7:28 [PATCH v3 0/2] lib/crypto: ML-DSA verification support Eric Biggers
2025-12-03 7:28 ` [PATCH v3 1/2] lib/crypto: Add " Eric Biggers
2025-12-03 7:28 ` [PATCH v3 2/2] lib/crypto: tests: Add KUnit tests for ML-DSA verification Eric Biggers
2025-12-03 9:01 ` David Howells
2025-12-03 17:43 ` Eric Biggers [this message]
2025-12-03 10:09 ` [PATCH v3 0/2] lib/crypto: ML-DSA verification support David Howells
2025-12-03 14:19 ` Harald Freudenberger
2025-12-03 14:40 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203174303.GA1417@sol \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=da.gomez@kernel.org \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@cloudflare.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).