public inbox for linux-modules@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Gomez <da.gomez@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	 Hannes Reinecke <hare@suse.de>,
	 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	Petr Pavlu <petr.pavlu@suse.com>,
	 Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	 Aaron Tomlin <atomlin@atomlin.com>,
	Lucas De Marchi <demarchi@kernel.org>,
	 linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	 linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 0/2] scsi: target+fcoe: replace -EEXIST with -EBUSY in module_init() paths
Date: Sat, 20 Dec 2025 04:37:31 +0100	[thread overview]
Message-ID: <20251220-dev-module-init-eexists-linux-scsi-v1-0-5379db749d54@samsung.com> (raw)

The error code -EEXIST is reserved by the kernel module loader to
indicate that a module with the same name is already loaded. When a
module's init function returns -EEXIST, kmod interprets this as "module
already loaded" and reports success instead of failure [1].

The kernel module loader will include a safety net that provides -EEXIST
to -EBUSY with a warning [2], and a documentation patch has been sent to
prevent future occurrences [3].

These affected code paths were identified using a static analysis tool
[4] that traces -EEXIST returns to module_init(). The tool was developed
with AI assistance and all findings were manually validated.

Link: https://lore.kernel.org/all/aKEVQhJpRdiZSliu@orbyte.nwl.cc/ [1]
Link: https://lore.kernel.org/all/20251013-module-warn-ret-v1-0-ab65b41af01f@intel.com/ [2]
Link: https://lore.kernel.org/all/20251218-dev-module-init-eexists-modules-docs-v1-0-361569aa782a@samsung.com/ [3]
Link: https://gitlab.com/-/snippets/4913469 [4]

Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
Daniel Gomez (2):
      target: replace -EEXIST with -EBUSY
      scsi: fcoe: replace -EEXIST with -EBUSY

 drivers/scsi/fcoe/fcoe_transport.c | 2 +-
 drivers/target/target_core_hba.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251218-dev-module-init-eexists-linux-scsi-4e91a16f7bdd

Best regards,
--  
Daniel Gomez <da.gomez@samsung.com>


             reply	other threads:[~2025-12-20  3:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20  3:37 Daniel Gomez [this message]
2025-12-20  3:37 ` [PATCH 1/2] target: replace -EEXIST with -EBUSY Daniel Gomez
2025-12-20  3:37 ` [PATCH 2/2] scsi: fcoe: " Daniel Gomez
2025-12-20  4:27 ` [PATCH 0/2] scsi: target+fcoe: replace -EEXIST with -EBUSY in module_init() paths James Bottomley
2025-12-21  3:30   ` Daniel Gomez
2025-12-21  4:02     ` James Bottomley
2025-12-21 10:00       ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251220-dev-module-init-eexists-linux-scsi-v1-0-5379db749d54@samsung.com \
    --to=da.gomez@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=atomlin@atomlin.com \
    --cc=da.gomez@samsung.com \
    --cc=demarchi@kernel.org \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mcgrof@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox