public inbox for linux-modules@vger.kernel.org
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: mcgrof@kernel.org, petr.pavlu@suse.com, da.gomez@kernel.org,
	samitolvanen@google.com, atomlin@atomlin.com
Cc: linux-modules@vger.kernel.org, Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH] module: show module version directly in print_modules()
Date: Mon, 29 Dec 2025 10:45:56 +0800	[thread overview]
Message-ID: <20251229024556.25946-1-laoar.shao@gmail.com> (raw)

We maintain a vmcore analysis script on each server that automatically
parses /var/crash/XXXX/vmcore-dmesg.txt to categorize vmcores. This helps
us save considerable effort by avoiding analysis of known bugs.

For vmcores triggered by a driver bug, the system calls print_modules() to
list the loaded modules. However, print_modules() does not output module
version information. Across a large fleet of servers, there are often many
different module versions running simultaneously, and we need to know which
driver version caused a given vmcore.

Currently, the only reliable way to obtain the module version associated
with a vmcore is to analyze the /var/crash/XXXX/vmcore file itself—an
operation that is resource-intensive. Therefore, we propose printing the
driver version directly in the log, which is far more efficient.

- Before this patch

  Modules linked in: xfs nvidia-535.274.02(PO) nvme_core-1.0 mlx_compat(O)
  Unloaded tainted modules: nvidia_peermem(PO):1

- After this patch

  Modules linked in: xfs nvidia(PO) nvme_core mlx_compat(O)
  Unloaded tainted modules: nvidia_peermem(PO):1

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
 kernel/module/main.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/module/main.c b/kernel/module/main.c
index 710ee30b3bea..1ad9afec8730 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -3901,7 +3901,10 @@ void print_modules(void)
 	list_for_each_entry_rcu(mod, &modules, list) {
 		if (mod->state == MODULE_STATE_UNFORMED)
 			continue;
-		pr_cont(" %s%s", mod->name, module_flags(mod, buf, true));
+		pr_cont(" %s", mod->name);
+		if (mod->version)
+			pr_cont("-%s", mod->version);
+		pr_cont("%s", module_flags(mod, buf, true));
 	}
 
 	print_unloaded_tainted_modules();
-- 
2.43.5


             reply	other threads:[~2025-12-29  2:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29  2:45 Yafang Shao [this message]
2025-12-30  3:11 ` [PATCH] module: show module version directly in print_modules() Aaron Tomlin
2025-12-30  3:58   ` Yafang Shao
2025-12-30 12:41 ` Petr Pavlu
2025-12-30 14:12   ` Yafang Shao
2025-12-30 16:10     ` Aaron Tomlin
2025-12-31  9:45       ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251229024556.25946-1-laoar.shao@gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=atomlin@atomlin.com \
    --cc=da.gomez@kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox