From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CB203DC4BB for ; Thu, 12 Mar 2026 16:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773334495; cv=none; b=i4PTIZ23m43fGfAeaQ83Exs9huis7hsqDK1vv06t2J9ZlCDafkFukhzwvkjjAtsAceod32/z2qUaOutdC1kAV1bh/f9YtXVLNw+q2XDoeIsCzQJ6MZQIUrZll7gOWqwwPZlMpmqQwj0BI4KvU3U7qph0RFp9k/UWKXwc9ye/1nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773334495; c=relaxed/simple; bh=ENv0+4bH9YdpFLGeURNwJ3+rEUsnNn74RNCtOl26SEA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aw7xzWmzbU4e1BSqAP3f9KPmVNpZlSjt0nAvxcMf7cJmaH/c+8JjXmwGf16KZplDnRV7dRpn/IaJYC8yOrvNboR8xjhnun++VEjot5TpwXfHxhIpGIvBDwihcC3gC+Rrp6KxpjpF40MvZDyuOGcCWff8uydXVR59LTDm9GDhNZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=TCUycPJz; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="TCUycPJz" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-509006c070eso10771361cf.0 for ; Thu, 12 Mar 2026 09:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773334491; x=1773939291; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VQXCfPVu6b6dIVECzm0C8AUD7IL7VvpSkD5+M4S95sw=; b=TCUycPJzE2fI+UEqk7FktReSuNB+qmtoLxCPQIhObf2GoM3FGGUoUzmOL4EcJ8nqrV 31wLWw0iuRrm5q/A3vl9oGJab4nkcB5GgE9L87TaBE5zWVhGKUEWMOYZrC4hQkz7+K+y MdSN9PZxg9+VlLOffdwRmQphGTW7UoGABbBRu3CtgROAhKqAusDMmmrNFgCXGsGgS+um 4b3n9KF8H9mgZuxtPx/c84lVtPd3kX8R2XT1vLZ+RjANCZT5FGS44RpBGA5cN1JRJXTn oCOtB2FnqO56y3+c6Fos0prISIneHSMHrQ7vAs2p/teTVBOn2DfneDCxuRpkTU9D9cja 6IGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773334491; x=1773939291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VQXCfPVu6b6dIVECzm0C8AUD7IL7VvpSkD5+M4S95sw=; b=rzHRn3O2V18p3ujAfhABPszkPVWaZTqwvbLqWIPUtf229sOHbVGJUO58C09D50espP ob21ETHQ4/eQtbP7VYXPCekJzkQoCSulV3WVYvX+RjzBNCBTAUhl1xa+ULCfvWlrB0yZ NN5+lsWDDpKLdCx3DA6ZKhI6CV2KQXPpJM3XyZow/OZHCo29NnnJbcdl1d55a9MbW0tR fo7x55bEUohQbTtDJvntyuXNY7/4Ncz9wfQN6bLXjVhK6d2/L098WX59Mmkyx7xKz5zF 00RGMHhwOPtpt2EL9qSBdKOMQ5yoxulL0pd+6dDPaa3f9kow9iat7r+mZIaolqYcOppo Erag== X-Forwarded-Encrypted: i=1; AJvYcCXjeq8sDQdtpUDAOe8l2dSeXKz0y7/yAtfZeWkDonkvQDdYvxmgk/Cmq4FFQrS98m2Fhk/xin33lmjo+OCE@vger.kernel.org X-Gm-Message-State: AOJu0Yw5omkw38tshqiVBzRJS3lrr0Xd1+BwNmBVaDxC3oRTvhkejR44 DQH+5g2ajmYIlu3apRUOXdig0F5vbWSi0O1yprB5VQp+WGU0MNpNbjgVZUqDhb2+w30= X-Gm-Gg: ATEYQzziRjBaGkS/6Uio969LDzEd+pHS7UvJ6cy0dGPeR3XmHXcaKCGu2ggj4I3vC4e D5voX4sWMQaa3Fn1ID0HwbGiOBMbA79Tl5JvX2ouM6O1ErurhBjANMRDBORZLM2ezSL84ElhJym nW/X1MHI87xeKCjj0s53wvkmu3QoFrKAd34gsJj+L3g5p5lMYR7vzVZd9AxNbGMA2/zfBiubat7 DOWvJqWp73kR/YlxSptt5G/SCyAPQKOyU0wB4IrHZBZ2fXvFM4qjltEU+btSRxi7eoaed1na00j 9ISRKxLsWJy5DHTJ1HGZWL27mQ8776CV4zXZNNRVNnHqv5pPUrRigdTA1lv0gYJDyFZMwMEUFF5 PMC4AHpWhyuxFzY2Rf7N6g48Dxk/wQbnCTV0BVAZKEyUipiHAxI6aiyk7p2m10Klo8nIE4Cj4h4 gUVzwVwEMgesJxH7mYA3T/AdbR9BileopIMA3deBcUioEdlcifmUMWk+iang7OyR9cNKanyw+EA z4OkM7u160tXJlgl0c= X-Received: by 2002:a05:622a:289:b0:509:44c3:5ffa with SMTP id d75a77b69052e-50957e10673mr1403911cf.52.1773334490530; Thu, 12 Mar 2026 09:54:50 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5093a119602sm36658181cf.28.2026.03.12.09.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 09:54:49 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w0jJA-00000006i8N-40X9; Thu, 12 Mar 2026 13:54:48 -0300 Date: Thu, 12 Mar 2026 13:54:48 -0300 From: Jason Gunthorpe To: James Bottomley Cc: Kuan-Wei Chiu , Philipp Hahn , amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev Subject: Re: [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor Message-ID: <20260312165448.GN1469476@ziepe.ca> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> <20260312125730.GI1469476@ziepe.ca> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 12, 2026 at 11:32:37AM -0400, James Bottomley wrote: > On Thu, 2026-03-12 at 09:57 -0300, Jason Gunthorpe wrote: > > On Wed, Mar 11, 2026 at 02:40:36AM +0800, Kuan-Wei Chiu wrote: > > > > > IMHO, the necessity of IS_ERR_OR_NULL() often highlights a > > > confusing or flawed API design. It usually implies that the caller > > > is unsure whether a failure results in an error pointer or a NULL > > > pointer. > > > > +1 > > > > IS_ERR_OR_NULL() should always be looked on with suspicion. Very > > little should be returning some tri-state 'ERR' 'NULL' 'SUCCESS' > > pointer. What does the middle condition even mean? IS_ERR_OR_NULL() > > implies ERR and NULL are semanticly the same, so fix the things to > > always use ERR. > > Not in any way supporting the original patch. However, the pattern > ERR, NULL, PTR is used extensively in the dentry code of filesystems. > See the try_lookup..() set of functions in fs/namei.c > > The meaning is > > PTR - I found it > NULL - It definitely doesn't exist > ERR - something went wrong during the lookup. > > So I don't think you can blanket say this pattern is wrong. Lots of places also would return ENOENT, I'd argue that is easier to use.. But yes, I did use the word "suspicion" not blanket wrong :) Jason