From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7CC431AF14 for ; Mon, 4 May 2026 20:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777927527; cv=none; b=a0pb6QqPm7wo6r+msbxsPRqAq69u+WqWhAq7GexS9n7ZTfH327u4ovM9KJRz38aeTPV6bHJH9O8nFmPomCJiZnraupwm4S7+BN2NdXQQvKp/JsslEX3lGzNRaYhgLwaWrLZeNxsY569LQO07wW0a8qfueJ5r7J69zV29suVDe+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777927527; c=relaxed/simple; bh=fQtxjBBlsfrbVNeHFs+VzNlAPJfQpt7R7uonizgiLgM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C+wbCgHa8dMAaTDfmvHBWO2yuh6SzMgnLFz0R/o37EH/cmvMVfSuoO6C9VomFcK/1Cw72BfKIndBAaRmUMlQdSPkRmhaiHBbARvOd/OwvsbTeOthXw/rHyMMJjokdsrKDUAtEgnj+WaJQlyHX0RwITB75mkx9Je7iWp3isLrj5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lv9eJXyq; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lv9eJXyq" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-4303eb92930so2872596fac.3 for ; Mon, 04 May 2026 13:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777927521; x=1778532321; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V0og+a8kac0IiyPYwMTiYKdKkV179BGjDAZzwYpwxKg=; b=lv9eJXyqRYzjGnA0fTU+PUUzBqf91Fm+wBP8kea835C5BTCD1IPa2NYiGq0vxENsly UEXSv3Klujg4Wwnx90jTLd5+8stby1/ODBRsKiSAhalTJ2aDcqD5kYtJvsyNDGYPAAAB OWP0jjJXEDUafr3CODz8BJc5pePccpcz+Me4fdFsexPUnKpK+b6NZw28BVX/+1+tNLLR ojH/VNt158fCCMrfyME65G4i6fAT7vPoAR/lOOO5jU+ut0vFRATLWQbiGUTkx1gn4ydd zBhS5t1715HcAzzSWieHh1TN9/3f7fAvW3Q/7OF3KAfK5C3TXdtHPb8eRYoxMg73eEUA /rhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777927521; x=1778532321; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=V0og+a8kac0IiyPYwMTiYKdKkV179BGjDAZzwYpwxKg=; b=IEiVKQK9anvotnK8Gf2Vvd2/wMjI9LCApbGb3YVfF5cQVw4ELJNn+VjFMKW6DzfGdD szSotkerD5bO0Tc2Jr+voV0Z5oIFzG0WY3V7Jz0c77V+JVrYBpicNnAcpv3w4+sLhyvK VEGJAcu+8yEM3YxShtz99bCFJUs6r6nAEzj4HnIVadfWJujQdPjPRwQfXxpaQ0wunYVO v5L8xnQGBNtRX8vJYTSt5MJsrZnY1KDCkMUHaif/rZ9h2h+gvgvGgxYhVaqTumYbsle0 EMdgA3TktVJ2giJzxvEPt4jZE8gTBjtdjy45oAJvkXsRvn9ncts7HagsNKINL9dMVATC hYEA== X-Forwarded-Encrypted: i=1; AFNElJ9OaxnTNae030Lcl8XPf+cKmdTUy7MklKwG7ZFGqtQnwiOSy70kVoOR0nFbuMngCT4yPbAfIcuOk6g47Dv3@vger.kernel.org X-Gm-Message-State: AOJu0YyeYnccOXtj1vCHYM/YZ7VPPZskag6glV6dNc4o2g+iesX0L32J yHJANHkGrkrlzJTx03YJM1artkXGUf21N31a1Fr1AILwuyoDHGw0BiTU X-Gm-Gg: AeBDiev1SUirSULksxdXaq8tncpi3vQjdk6RUidhlTTsxmAoBhUG6s68YCrMSP/p+fh zEC2/jHIwiNyBivDzOeNoeFYWee85pLiOazHE4rVlWXGx2f1gm+tjTrpch5qBZl1a1G1xwXvT1u ZzCJI37o6VqC66AzOTdacmDAlybXuNNalyikrYSaYlSAB+A3tRXdcIt4fCghgfUT86u2vPOHLZW vjhG64nruWyFKcbojRKD6NsDn/qBPCA5A125WkRbB1NB8R8hRwsi7mB/uXBZ6Hr7WjTdKZFTLQF OZ7vKTyVV79Vw5WKyLQqsAS4eQb0mOIXCuy0EgR/0Rtea08tnw/esywSyCsOJVD5/Z1/63lrt/J BFiYH7Wl9T+id5V0oU6uVCO5D29A+5fibKjErCKjfBEgI2UWFNeT405UdinkGvOGl1SXaoLttn5 4VOdximjlrelJxQ5OCI19v5Av34KtPjahkCUMg0c37p10OAV5Zflf2H7WeGDicCTzJuDKsunZB X-Received: by 2002:a05:6820:1687:b0:696:6bf1:b8da with SMTP id 006d021491bc7-69697d69e55mr5450314eaf.42.1777927521511; Mon, 04 May 2026 13:45:21 -0700 (PDT) Received: from [100.82.231.29] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-69689266bacsm7144713eaf.0.2026.05.04.13.45.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 13:45:20 -0700 (PDT) From: Jim Cromie Date: Mon, 04 May 2026 14:45:10 -0600 Subject: [PATCH 04/17] dyndbg: make ddebug_class_param union members same size Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260504-dd-cleanups-2-v1-4-6fdd24040642@gmail.com> References: <20260504-dd-cleanups-2-v1-0-6fdd24040642@gmail.com> In-Reply-To: <20260504-dd-cleanups-2-v1-0-6fdd24040642@gmail.com> To: Andrew Morton , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Shuah Khan , Louis Chauvet Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777927513; l=1479; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=fQtxjBBlsfrbVNeHFs+VzNlAPJfQpt7R7uonizgiLgM=; b=ttLRyXE6cZ85k5IAGBKzfNeOHmjsQMSdBe0oJuY+GuqeR5kO7dRO2UTAOXb6Z/uCC5xzVY3Uu k7pB5IiC37BAmfaXmLuWDjqegWQkmZL7ULDACaH/AQppR+9Hq0uDuxo X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index a10adac8e8f0..441305277914 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -104,7 +104,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index a9caf84ddb22..ffa1cf7c2c72 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -811,7 +811,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp) case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } -- 2.54.0