Re: [PATCH v4 12/25] dyndbg: drop NUM_TYPE_ARGS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro DECLARE_DYNDBG_CLASSMAP relies on ARRAY_SIZE, but the patch fails to include <linux/array_size.h>.
--

commit 464d8da755ec7b15d6bc584121b284d4801591c5
Author: Jim Cromie <jim.cromie@gmail.com>

dyndbg: drop NUM_TYPE_ARGS

This commit replaces the custom NUM_TYPE_ARGS macro with the standard
ARRAY_SIZE macro in the dynamic debug classmap declaration. It removes
the NUM_TYPE_ARGS definition entirely since the array declaration is
complete.

> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> index 78c22c6d23128..867e3978675f0 100644
> --- a/include/linux/dynamic_debug.h
> +++ b/include/linux/dynamic_debug.h
> @@ -121,11 +121,9 @@ struct ddebug_class_param {
>  		.mod_name = KBUILD_MODNAME,				\
>  		.base = _base,						\
>  		.map_type = _maptype,					\
> -		.length = NUM_TYPE_ARGS(char*, __VA_ARGS__),		\
> +		.length = ARRAY_SIZE(_var##_classnames),		\

[Severity: Low]
Does this require an include of <linux/array_size.h> to keep the header
self-contained?

The DECLARE_DYNDBG_CLASSMAP macro now relies on ARRAY_SIZE, but it appears
the header that defines it is not explicitly included in dynamic_debug.h.
Could this cause build errors for files using this macro if they do not
already happen to include <linux/array_size.h> directly or indirectly?

>  		.class_names = _var##_classnames,			\
>  	}
> -#define NUM_TYPE_ARGS(eltype, ...)				\
> -	(sizeof((eltype[]) {__VA_ARGS__}) / sizeof(eltype))

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com?part=12