From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32EC53B5DE9 for ; Wed, 8 Jul 2026 02:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783477132; cv=none; b=Swk5WXPtUqiYPHn+BYUwvsOLkQ4Hh3obyDpnO8cdmgVI/ebbVNY1LkTJcKu/kFTH/Nl3M0FFVwNXv34Kf0H8mZNEDjfy69Mgb9QaGj1DwTLo+a+zt7bKebpCmJfGHzrGf58yh0xnc8/SUErD9wsvYQVZ5Oa9jcLbfv8NYXc75iE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783477132; c=relaxed/simple; bh=LKcWOgQjOSSos9Y+vfT5MoZ88a0A/4utKPeiOYeZmDI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lLfdv/fvTpQ9Fpa2gy0V0P6bKsgIQreFtDThDCdkw06vnd53AuKNq3XMitxP6cuHMBcz1xh/YFy0XmLtc8qc/3syx1vuasjcZ6QKnTuVCZ2Uxv7oBGnhA/0JaZa6hpFH2qfI7X3ozfMYSfvwa569v0YviG4b0lCCnAMbt32W4zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CfM1tA0s; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CfM1tA0s" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-489f3611e0cso152931b6e.1 for ; Tue, 07 Jul 2026 19:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783477127; x=1784081927; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PMdUWN55evypGlZW0ubXM0NSUuJGy0J2aNFMM8kAHEo=; b=CfM1tA0sOmeAy+XexSBYsz16Y/P72r/aTvXSOSa+EWUGrnf9Q3GI4MT3icCmQfhxuE F7QB2FG62wipVpiRz6WghTXsruMDZMzc4+P+yGdwQ5T4wWpmBvljQCOHrIYzNkOprP7D daO/PyPn30/aYBYTkIOkWJs9U5bs8I37ZaMgUEkhA6x8s/HAWOb0pgubfkkKd1Cviu67 1dhUGc+xd+1gvdxU+aA2RnbhuLSLM5pp8UnGjRpczcuQdXpjl9+d2lJvbpR66qel1N6M HGxjbE8nL1wYUyDqUC7Lk9GuX0IiUQBz567atUe4IMDtrj60GR94xdOfQuHrhc2gS3tq RrMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783477127; x=1784081927; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PMdUWN55evypGlZW0ubXM0NSUuJGy0J2aNFMM8kAHEo=; b=ieyEc2/KfbPRt4tcj9eFGsaGAji5cd7e6bBnklBaFumuEyYznBT8+CkESdRa+CxFS1 Ksx0abvX0tbrJjw/jnfzES6Ybf/LJuM8jipBdXXDNfecvUF2xIFOW8VjGwXNtPLKuZlI SWky/Q1qpOZanelNQS3mLJ5dvKbV+75JlL2spjBblh8tjTNhdkdINSey2VdAsDqBOD1P UsqHrWWxW6iYYQ8uLlB1WXwDVkN8EDbaAekhMDLLS8bW5xKIrsela7X9lmhO7qos4Lbc gdgCfLB7nu643mYFrZLB0S+tCYmAr1LHjtT4TMtGn+brrg7cIYq1j+udqxl5MhGbmLUx JtGQ== X-Forwarded-Encrypted: i=1; AFNElJ9jixWh29jJB4HbkQHOMl4fDPKB1CaKxki8KtMOjzu1dMnnkV0aKJuXZamThxpBj7zi5z/Zk9/orX5PF7JB@vger.kernel.org X-Gm-Message-State: AOJu0YwzfwpzBQKCq+0vuKiZwgPfnaOkq+CQJujs1/bqNbfKH0BR3urF PxHsxADVosu7qUef7VvPO16LLOO7HxlRbhRcyiTHfwnyK4fXWyvebI91 X-Gm-Gg: AfdE7ckhUqAbnsrWh3IEwc/eLv4TCExLnLiFqGCVPs2zuaOdOQiFLGlfECElmhRb18H aQ4wdpo2cgb7OirSHEnfxpLtMr+aoIENgXJKVfyHmXFSU+PbdhVRQPqWVfXi2NJWzWxCBORyE+k Bt+H/p5pD0qTRS0xfXByDxLZxaey5PAhIFf8sTmuYY8YAzPGobgKpOHW+2fAwHV+GQzuXn3K8RS KWFnxaRinTTmcSvnNT92AVALLM5RQjrWIm39UKGZYA2gv7TemFjc1sRgxeaEF11ZEVcKGcJ0DAU Mj1pcpvNTrukP0I7M0+YCk5JtlkawDt8IGsS8OqC3gzckd8SN51R/a56THe85HKj95sYePJm8hs e19P3SNEAtL6w8R7Abq/VMb7ui18AqyuphsNc8UYjuC3SdP5eZ6MPal8EdVgxePpExnKcsqc1kD r0jXeosng/dmIaZSdgqca8E5StMSccw8nHKV5rstWU1vh20CGdu7M= X-Received: by 2002:a05:6808:1511:b0:492:2420:a722 with SMTP id 5614622812f47-4a20541901fmr294508b6e.20.1783477127013; Tue, 07 Jul 2026 19:18:47 -0700 (PDT) Received: from [192.168.0.245] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-4a1aa006f74sm799975b6e.0.2026.07.07.19.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 19:18:45 -0700 (PDT) From: Jim Cromie Date: Tue, 07 Jul 2026 20:18:12 -0600 Subject: [PATCH v6 12/24] dyndbg: reduce verbose/debug clutter Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260707-dd-maint-2-v6-12-381f3edb0045@gmail.com> References: <20260707-dd-maint-2-v6-0-381f3edb0045@gmail.com> In-Reply-To: <20260707-dd-maint-2-v6-0-381f3edb0045@gmail.com> To: Andrew Morton , Jason Baron , Greg Kroah-Hartman , Jonathan Corbet , Shuah Khan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Arnd Bergmann , Luis Chamberlain , Petr Pavlu Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783477102; l=5280; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=LKcWOgQjOSSos9Y+vfT5MoZ88a0A/4utKPeiOYeZmDI=; b=8Lgqc9DREOjM+ZVTh2w6qFyVZbsU0Kjvp3BUcN6vC2a7lzixoefXPGo5M3mnkjEj+duXIIScm 909ikVkabvjB6DYCgRISjXbILVp6EA3O80ayAxNToEMAyJzcVRudXO+ X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xffffffff dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: no matches for query dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' flags=0x1 maskp=0xffffffff dyndbg: processed 1 queries, with 0 matches, 0 errs Also drop several verbose=3 messages in ddebug_add_module. When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. Unmatched query diagnostics are intentionally restricted to verbose level 3 (v3pr_info_dq) to reduce dmesg output clutter on standard verbose levels (verbose=1 and verbose=2), aligning with the overall de-cluttering of dynamic debug logging. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v4: rename vpr_dq_info to v3pr_dq_info to tell its active logging level adjust some vX levels per doc'd intentions v2: RvB after SoB trivial change to verbose-debug output line to output the actual "module" keyword rather than "mod:", and do so only when the module is constrained by the callchain (ie as part of a modprobe). was: query X: "(keyword value)* [+-=]flags" mod:* now: query X: "(keyword value)* [+-=]flags" or query X: module FOO "keyword value)* [+-=]flags" IOW, adjust output to reflect the input grammar more closely. drop-info-parsed vinfo-applied-nomatch dyndbg: tweak verbose-levels per doc --- lib/dynamic_debug.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index efe12fac6363..2e321b7eb957 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -128,7 +128,7 @@ do { \ #define v3pr_info(fmt, ...) vnpr_info(3, fmt, ##__VA_ARGS__) #define v4pr_info(fmt, ...) vnpr_info(4, fmt, ##__VA_ARGS__) -static void vpr_info_dq(const struct ddebug_query *query, const char *msg) +static void v3pr_info_dq(const struct ddebug_query *query, const char *msg) { /* trim any trailing newlines */ int fmtlen = 0; @@ -280,9 +280,6 @@ static int ddebug_change(const struct ddebug_query *query, } mutex_unlock(&ddebug_lock); - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } @@ -491,7 +488,6 @@ static int ddebug_parse_query(char *words[], int nwords, */ query->module = modname; - vpr_info_dq(query, "parsed"); return 0; } @@ -515,7 +511,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -529,7 +524,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=0x%x\n", modifiers->flags); /* calculate final flags, mask based upon op */ switch (op) { @@ -545,7 +539,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) modifiers->flags = 0; break; } - v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask); + v3pr_info("op='%c' flags=0x%x maskp=0x%x\n", op, modifiers->flags, modifiers->mask); return 0; } @@ -574,7 +568,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) } /* actually go and implement the change */ nfound = ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); + v3pr_info_dq(&query, nfound ? "applied" : "no-match"); return nfound; } @@ -597,7 +591,10 @@ static int ddebug_exec_queries(char *query, const char *modname) if (!query || !*query || *query == '#') continue; - vpr_info("query %d: \"%s\" mod:%s\n", i, query, modname ?: "*"); + if (modname) + v2pr_info("query %d: module %s \"%s\"\n", i, modname, query); + else + v2pr_info("query %d: \"%s\"\n", i, query); rc = ddebug_exec_query(query, modname); if (rc < 0) { @@ -1163,11 +1160,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname) { struct ddebug_table *dt; - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); dt = kzalloc_obj(*dt); if (dt == NULL) { -- 2.55.0