From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE477E0FF for ; Mon, 24 Aug 2026 01:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787536039; cv=none; b=iGbZvp+p4Ft8P1Ynk7Oibyk70a8Sb6Hlq4WJYH1YCobClnfbMfqbisU9oPOHACtSn4hjVU02wqBQGBk2ibfbGfVK3CeQdMR3VUIgfxkU+q11o0FpCKtkORrPeUjVRrK3DxRxg8IokZc8fdTuGPEij/X3e09ogovm+aPp3O1wjyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787536039; c=relaxed/simple; bh=GMXp/uzjwMPTYkYu0trgCHPdqOIOW0rq90aIR8oBimE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Cd4Dw7uVkWTytezCF2vhvEbugH6q+NtvahRC9gN+8sBaOOZ9oECuSeYrCmrb8PzwhfJCluBPup+mbCY/+1gF2LCz+qkf/NUnBGdmJf56BJGGUvuHsfZAKWhfskgwGG4yCMIKtvvmHQ5f6VAboTPAWcT5AsN0sod7UY8MmQc1Rlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gTg1k2h4; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gTg1k2h4" X-Envelope-To: linux-modules@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=GMXp/uzjwMPTYkYu0trgCHPdqOIOW0rq90aIR8oBimE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787536035; v=1; x=1788140835; b=gTg1k2h4x17BocxgJIbRcTKRVmdk6CN3x6sULp0nrNiPgHuOUgwz5tPToUkGmxgmKv35jw65 jbsRGpVtHwA9+YnVkWqjbu63sEKFtohxqkB97+UHsTVTXy2A7zun0YHLeT1kNafVyDVIomCTc6F KD7hBLRROt+JZT7G+Za8FvmM= X-Envelope-To: linux-modules@vger.kernel.org Received: from localhost.localdomain (116.128.244.169) by smtp.migadu.com with ESMTPS id ffe8640577d465e7; Mon, 24 Aug 2026 01:47:05 +0000 X-Mizu-Trace-ID: ffe8640577d465e7 X-Migadu-Flow: FLOW_OUT From: Hao Ge To: Suren Baghdasaryan , Andrew Morton , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hao Ge , Sashiko , stable@vger.kernel.org Subject: [PATCH] module: fix lost error code from codetag_load_module() Date: Mon, 24 Aug 2026 09:47:36 +0800 Message-Id: <20260824014736.35026-1-hao.ge@linux.dev> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If codetag_load_module() fails, err is never set and load_module() returns 0 after the module has been torn down. Fixes: 044d2aee6c57 ("alloc_tag: handle module codetag load errors as module load failures") Reported-by: Sashiko Cc: stable@vger.kernel.org Signed-off-by: Hao Ge --- kernel/module/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index 46dd8d25a605..afb810f0154c 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -3568,7 +3568,8 @@ static int load_module(struct load_info *info, const char __user *uargs, goto sysfs_cleanup; } - if (codetag_load_module(mod)) + err = codetag_load_module(mod); + if (err) goto sysfs_cleanup; /* Get rid of temporary copy. */ -- 2.25.1