From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AECA23112BD for ; Wed, 26 Aug 2026 15:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787758559; cv=none; b=gDHQrN2bmGMJp8vMVbjx8vciD8zze53IMs0/q1rhivpYSfXzTgyn8sNxvHlWWVf60cP9tsVtcAYHxS/AZMihoBcdY5IVMuxcb4OtLdoMzNXJTkdtChuJhQe+v7DRKFYyYdkxo0Nvq9mWEa0imgh43pgqIftTT5K0uitGBRdKL+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787758559; c=relaxed/simple; bh=ASVPig2RbtLJupuuu44qrmNIwC0FnZunoekjk+DUNY8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bbjDEo/XDfOgv80A/TzVn6U1nDBYPZ7Wh+1+XdGxhpjoQhCsSerxDsseLAagT1cXEHFhSU0Ip4wXQQYpRyTp1OfElcNeOh2mBryiATRlLTfwROSBZwx7zobg7vE+oS7OUM5uWE3oL3tTNK3Lx1hBN6hJcxYe7YkldiPKlOvRaxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IR9tPp52; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IR9tPp52" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c2530cabcf4so62108666b.0 for ; Wed, 26 Aug 2026 08:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787758556; x=1788363356; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DftFo5v0HYb4sNCC2CkJoMxRuwrXKdG0zBl21yO9LPM=; b=IR9tPp528Fe+AL0FMXXAnvK8zpb6b3GKDMB+mD75iJS8XgbHaeyB+9QNy/XrPhOQRP 5Ahsmjzjz7zskE6HPwnSpPfXkdrPo7Qo+iCXcSzI8GxnyYfGgEKfkV4bNCS5r8HHMj4B sedTvw1XbsT0wCsXKeC/v2HFbMs9n6HSQ62VCFXL4pgWLpwYMrXWY7qelE+QI92LO5+u VJDOCPmIKaKwrbaOaTpApBw7w+FQRGMX4R4Oczs8WGLHYb+1Qw37TfJmLhYSlOuJ5x6E TGoK5ihxW/QaKYKR4/pitmpw1ZZ1XHAuA1etBLc3FVCdfUqk1QALH87yU2AaAYJAJFyR Lz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787758556; x=1788363356; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DftFo5v0HYb4sNCC2CkJoMxRuwrXKdG0zBl21yO9LPM=; b=VtB9Cgf3Y22SAJkx4aHqyW6NPuIST/ECacdU7T2KGC3+kiCumi3Caeqj1SStMU4Lnm X/iZPKNszb0YSaFjqOkCw32T91Ig4YaSw9QUzX57qFVT7YkdlG34Fnvaisv+G6nCvIGe MZWovfF/hHpZ+zMadK0IUd+dtdQB5T7sVipVPLrHjMm1+DaysdPY4TFyGdqvUcwPBFwn cAwPrSFd2o9//xKlHzq6iPQY49zW0Q1RsKwb7Ein8Jg8Ea6EX04tnjZroyT4YSoSTvCP wo3y8OG3vIq+K5AUklUUAFIxXsbX3e+KQ8fIS4XEu5bb9oX29Z9rv/XM2U9jPS8AcZo8 iMnA== X-Forwarded-Encrypted: i=1; AHgh+RqQYmcr6wy9Rx/DrdqaJ91ejlkEVLT71h5/ggULHwednvumUOfzP1nH3E6UstKa48qJuSqpe7WkalAJUGOX@vger.kernel.org X-Gm-Message-State: AFuF++lIyI/ofLDyIchqllgqEg6otKziBzw0VkKPRqS8R58VECD/9QPw XXu2/HCDcUdwPpRB1S6k3FtFyMRK6IwcsTFqOlIu4f+/qB8gpSZqtttb X-Gm-Gg: AR+sD11W8rWl2HLnmY+mFlFCii8Ix3MzsrcVGMgYbIhuAaM2lc9RokkRixsxZFS8A5V 5285HngdjG3FXVPLX8puSk4cuQQIG5hVj6KCIi2Cg6mb0onKjZF/6Xmf48qaY4rbVK4Nrnsgcnp Ob9hg21ikJ+hcexaspRjHvaHddybCkEKqamdT3thIfGRVFl3n2sEul4TClGTowdZDctcPaEotMV wDd5gcQtAfCQg1qRdcktSaQkkUgY9wwYXyZy15Yo4iKoUSr4Jm4IiwlpL3s+R1oqisUpod3wdBD 9fxEK5HUYRMvBI5xjHRBHHRnJKB0V/YOrC2f6+cIuLpEeHEmIVFjF5zjXeVdzx7gILKmLqJJXS7 BqpDEy1Tju0HfRVA7nEzz77pxKES9Hz2Eyvye5XQ19bhBU8kisYJahUW4wRe6FTiu+3GdUeA4TM OSk7yUd4WQdWeJ/GXf2wR3pZX2SbC+j8PZT3uUj08I+dI/g1IKRrYRFKl5OyZmQejpdmfs X-Received: by 2002:a17:907:7249:b0:c21:752f:c3f7 with SMTP id a640c23a62f3a-c250bc127b0mr959446666b.18.1787758555453; Wed, 26 Aug 2026 08:35:55 -0700 (PDT) Received: from foxbook (bfk5.neoplus.adsl.tpnet.pl. [83.28.48.5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c250a72d6dbsm483312166b.24.2026.08.26.08.35.53 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 26 Aug 2026 08:35:55 -0700 (PDT) Date: Wed, 26 Aug 2026 17:35:49 +0200 From: Michal Pecio To: Greg Kroah-Hartman Cc: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Jonathan Corbet , Shuah Khan , Randy Dunlap , "Rafael J. Wysocki" , Danilo Krummrich , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-usb@vger.kernel.org, driver-core@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] driver core: add TAINT_FORCED_BIND for when userspace manually messes with devices and drivers Message-ID: <20260826173549.18c8a89c.michal.pecio@gmail.com> In-Reply-To: <2026082658-statue-census-dc39@gregkh> References: <20260826-bind_taint-v1-0-52b05f4a965c@linuxfoundation.org> <20260826153311.6340efcd.michal.pecio@gmail.com> <2026082658-statue-census-dc39@gregkh> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 26 Aug 2026 16:25:42 +0200, Greg Kroah-Hartman wrote: > > I think you confused 'bind' / 'unbind' with the likes of 'new_id' > > and 'driver_override'. Try binding xhci_hcd to NVMe, you won't get > > far. > > It seems to result in a failure report that people keep sending random > patches for :( It results in write() returning -ENODEV. You can't bind random drivers to random devices out of the box, you need ID overrides. And then you don't need to bind manually, the kernel will happily select the wrong driver by default. Authors of the recent xhci and thunderbolt patches admitted that 'driver_override' was involved in both cases. Meanwhile, Syzbot also found a stupid write to freed memory in USB core when HCs are unbound. You may say it doesn't matter, but: * USB HCs are hotpluggable thunderbolt "gadgets" these days * there were plans to alter this code so that UAF is triggered by hot removal of the USB device, not its parent HC IMO the actually meaningful change would be to taint driver ID overrides, because that's the known risky and crash-prone madness. bind/unbind taint is noise that will be ignored. Regards, Michal