From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6EF937C0FC for ; Fri, 11 Sep 2026 15:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789139121; cv=none; b=BC5ovrXFv9CFImu5xz0b9pFuJLCUImJDBc4jqd6WUNyCzIzXMTQuufE9p09gCAgNJ2FkhfDhKwBMoJigfDc+vrki0NLoUuzM7zk3I8T4j5Uypi4u/ovQ8gLk4UHfxQqbvzuaIS3ONgVDhuZ4Ds+xIGDu0K7fT1E0A0WfmW/tMAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789139121; c=relaxed/simple; bh=JL+uluzocOxsNsOaPXlEzBUTr48C+sSlS5wULgBtFtM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WN0ELc4hMyVeLBSLlpB0pYiCh72J5bXVA2gLtqkShyEhqJYFNWwFKZQCV02bRTfK5qAwjOYeR+NWbd3Xrf+8z3xJUVFxrmGrsS4aakqAcwj+3WupIF80TqQqlgMEkwjavAbdGt5cyz1CkMZK+Egk13bbR4Lmp0Sw+PR34CUnlEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=DPoBfuQE; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="DPoBfuQE" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-482f2ee53e7so703207f8f.1 for ; Fri, 11 Sep 2026 08:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789139116; x=1789743916; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=a258DNEK6aR0v+xDimWu2caaAUdwCvMljBObmnBjN5k=; b=DPoBfuQEnSW5Lg5efeT4TbUM3prqvIUhPd4e5hEY0qDOO+rDm2xucBa0yhmFynP+N3 WR6a2Gc2Gg4xPJ+/pv/3qqwEuHoTM9zVDN1DceSyYg43HeUzI6htFkmmQett3GeRPX+S xEQ+K4u9guKtuLvcCJLF7kLfaqhMbAviVHOQ5JWBbVd5vePW+cWI1A/DKoY3mCEzMOkk Y+Hv+yx7UvK8P1P114QbrqXOITDqKZJ8W42XE0Nr58ksWIM7Wqi38tAFD1RGDUieECyv 64JK9yPfgwbchvz/IWFnDoeyM4gFoUNujTtTHeHvmhhHodv9ecWYuEs/+7UKTO4ibSdO p3Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789139116; x=1789743916; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a258DNEK6aR0v+xDimWu2caaAUdwCvMljBObmnBjN5k=; b=MVeEJpSksae5DzNuA+IrJICDsViRSTLKpwA0Qox4HZXrtTjyAllXB+DH77W/yaq8ey I6XpIRAr6kGkTQejmyztQr3PD8i1fJfalqQztn+l/WP6OZC6GL7aF+V6OJOsMZWmqj8P iIpjiMC4vdHyiM0BQlx+zbHwaNcLVgRobX1s9Tz6JiMoOWG0YF5atuRnmSjIGhEC30s9 4w6mpehti72h6Bno2TqQ8iZk4pTzz+tKm5fMAx7hhsHoruzT368WhJcC6WByetIdO0tY dKkOB+o0LJyFYSoY8M2AqlSyksgOEfBgmcJy0u44F1GE+EuO5qVk6oa9CUMSQk3T3YKj Kqtg== X-Forwarded-Encrypted: i=1; AKwUvBxzxtkBJoKqssmPzpBd7d0AXVrKbx+o9AsT1Bv4CTHdaPNXIqXmDwviZi1avizGoVT+uVEQCpQix1UXEPTV@vger.kernel.org X-Gm-Message-State: AFuF++mDMX0jlIQCOsrhLaVW2R9LJJgsO71Iznqto7jgouxfjUa46G07 9BN2EF53f97/eIScS7WauBJa1UDrcpHNVxazsG0ZtPD3C1mFDc3ivVIy1IjlxnbTEaI= X-Gm-Gg: AYBFou1JFumwKaOGqlmCpfAUNwl5J0xPkAoMRgsgPhDokf/Nqf/de9fhenvX+4KMN/S JC93sSHWVcGuvQ+ATZ+cIdzt62FcXT6pQ9Hgf4Qh/PjcnHmJsu5E5IhITPUWKdRMXV+zguBDg1W kQeUxGfFrRPfLnFLjMUC8PNHUC5d48nkg1hBLEZ8kU+TMUme2GPlmJYMmS7PevNCo73moyyob9m vNPWfh3AcDPyEtl3OuekVk7wvPiln3PzxSnDmBFyJQNDo6fHNRMW9jSKu4UPBMfVoWrxSboGQqX aBJaJYHvIndUcEk3SP+vBUJVJHBjCvZ37dVYsDVcIl5bztwxZDTTNkKrfc81l2UIjW7qYNDXehg gvbHHWsHlAqz7sZsgBPdmdhzfrOeNtcTGfZZ2MjOOk7l/ADRKJEgOsHX6UaDE6aNp1yxfG6xmen gVSDuOKqlNQKDt3syI2xjRkSglAiJsFkx2JPlvZzyzQ0Ly0T5FZ8aOUMAzDfPlblvi/YMskTXo/ BuDcuY= X-Received: by 2002:a05:6000:491e:b0:486:f4b6:3bce with SMTP id ffacd0b85a97d-486f4b63c4fmr559176f8f.24.1789139115924; Fri, 11 Sep 2026 08:05:15 -0700 (PDT) Received: from localhost.localdomain ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-486eb350686sm6853579f8f.27.2026.09.11.08.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 08:05:15 -0700 (PDT) From: Petr Pavlu To: Jens Axboe , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Matthew Brost , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Cc: Simon Horman , David Airlie , Simona Vetter , Francois Dugast , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] module: Remove the error-injection.h include from linux/module.h Date: Fri, 11 Sep 2026 17:04:06 +0200 Message-ID: <20260911-module-include-error_injection-v1-6-5da895d8c84d@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> References: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit linux/module.h appears in roughly 15k #include directives across the kernel. This makes it a "hot" header, so it should avoid pulling in unnecessary definitions. The header currently includes linux/error-injection.h to obtain the definition of `struct error_injection_entry`. However, this is unnecessary because the type is only referenced in the file as a pointer, for which an incomplete type is sufficient. Remove the linux/error-injection.h include from linux/module.h and add it to kernel/module/main.c instead, where `sizeof(struct error_injection_entry)` is actually needed. Signed-off-by: Petr Pavlu --- include/linux/module.h | 1 - kernel/module/main.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/module.h b/include/linux/module.h index 96cc98568eea..b3a3d5827384 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -24,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/kernel/module/main.c b/kernel/module/main.c index d0e1e0bd2ad0..f1392c10907a 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -60,6 +60,7 @@ #include #include #include +#include #include #include "internal.h" -- 2.55.0