From: sashiko-bot@kernel.org
To: "Petr Pavlu" <petr.pavlu@suse.com>
Cc: dri-devel@lists.freedesktop.org, tj@kernel.org,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Anna Schumaker" <anna@kernel.org>,
"Chuck Lever" <cel@kernel.org>,
hannes@cmpxchg.org, mkoutny@suse.com,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Jeff Layton" <jlayton@kernel.org>,
linux-modules@vger.kernel.org
Subject: Re: [PATCH v3 3/3] module: Bring includes in linux/kmod.h up to date
Date: Fri, 11 Sep 2026 14:52:30 +0000 [thread overview]
Message-ID: <20260911145231.1D1981F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260911-module-include-kmod-v3-3-6ebccc3e0731@suse.com>
> Including linux/kmod.h alone results in 1.5 MB of preprocessed output, even
> though it provides only a few functions and macros.
>
> The header currently depends on:
>
> * __printf() -> linux/compiler_attributes.h,
> * ENOSYS -> linux/errno.h,
> * bool -> linux/types.h.
>
> Include only these files, reducing the preprocessed output to 10 kB.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-module-include-kmod-v3-0-6ebccc3e0731@suse.com?part=3
prev parent reply other threads:[~2026-09-11 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 14:46 [PATCH v3 0/3] Bring includes in linux/kmod.h up to date Petr Pavlu
2026-09-11 14:46 ` [PATCH v3 1/3] umh, treewide: Explicitly include linux/umh.h where needed Petr Pavlu
2026-09-11 14:52 ` sashiko-bot
2026-09-11 14:46 ` [PATCH v3 2/3] time/jiffies: Include linux/sysctl.h for proc_int_u2k_conv_uop(), Petr Pavlu
2026-09-11 14:52 ` sashiko-bot
2026-09-11 14:46 ` [PATCH v3 3/3] module: Bring includes in linux/kmod.h up to date Petr Pavlu
2026-09-11 14:52 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911145231.1D1981F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=anna@kernel.org \
--cc=cel@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hannes@cmpxchg.org \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-modules@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=mkoutny@suse.com \
--cc=petr.pavlu@suse.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox