From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa2-f12.google.com (mail-oa2-f12.google.com [74.125.231.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B469583AA1 for ; Wed, 23 Sep 2026 22:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790202919; cv=none; b=HUD4+0+maO8q1r+E1e8MYje8X45tQ/B5Zs5h3HT7baqH2HBjOXGcMiJbupuP2myLmVwuMKoSHwv3UHbejH7iXgbXYLzWrEOGhbUIENNJaUjnAzdyndZN3H2csx1mR9k6wpw7CWhu4CSjT8ZMs3E3cRmFz0TqJkELS4zZ8SlVAQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790202919; c=relaxed/simple; bh=4cPDF74uOTh8cYJJIZjBbCuC9sfRIaYWwiE1nN9E9C0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hHTZ15cqVz3VBcPZgh0G/xdv+gX4uEFjXU853u7JivuH66q4b5nbC+lppujUzoFVROJfnB3r46BJNU9TigbOU3+PmrtcyCLJXhVLfYmJavgG4NcX8mkHv9naxzHuOZEblGH24UhUmOwLlZ381nK22TsHKzYQWi5qZqEqMeotIW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n2fXbzBy; arc=none smtp.client-ip=74.125.231.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n2fXbzBy" Received: by mail-oa2-f12.google.com with SMTP id 586e51a60fabf-46a63c34533so1396891fac.1 for ; Wed, 23 Sep 2026 15:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790202915; x=1790807715; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nkNAt1DhrZGGdf2x0u/TLTqqqm1yS1gyvZGd21ceXy4=; b=n2fXbzBy/EEI/C8TbJFGW0kSWzV4Y/zCfw2WhME/w94EEujtNf7Xer+McyoXlS1L9N R/ZfEAlvaMlqtVBZkQug2V74B5FNLAjILbjytAgqRNVtcZXrYHknDrMrWmWRy0PKcX1D FWDHurpF34JXeoJ7h7fbaLIyo1sLUj55q3mNIdYJGdJEznUInl8C21UVH2jhrkJgfc7G P+vj+hUAMJgllxPX1Jy2d3f2o2ZOlWeqzBhJEcNaDf5e9R/8ILjCZDD6Sm6SjwvrhDhG a45zLkBeD544VKjijHxhDuywviwIstueMWTumcPe4oA03Qnd5IBbNCVn41S15xAfOMcJ GIuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790202915; x=1790807715; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nkNAt1DhrZGGdf2x0u/TLTqqqm1yS1gyvZGd21ceXy4=; b=D5/5TYmHsxycCC9rDgU3iUN/FqidcxzPBwPacX6kyVnPPaNyHUw2DmVvocy1i0LSRl 8iG5uWvpJOyXVOVcTPEAIHSHTHWfyImZ0wBCsI/KJ5TI+9fR+jnXsgMJlDh/UuHSJiS1 wkXX3vf70PjlVjGXOFbauK9D5aqUwmE5sJhX0Ptdbq4S9t1i5nC17qX1o/kOD/dGRKXw PJu17nLMyLLBQCaZOiEHgm5YsFSGpuF/Xqcansk5tb21S/NRz/mvq2tSqzTpc7DhjJ0N Z5d7C2j6AQhmxqKDV8BvNBM71hvBJQnI6PtaupJJD2yzE7KALZ+vokrrLYzRpI0isDbB suWw== X-Forwarded-Encrypted: i=1; AKwUvBxOvv2NCW8vhtvfM2ayIum3agzzIdOMHUTKCKh4lbcHlZuOtnR3i9BaUfX+zRL4Oo5UuIfbPDSY98Zs6EIe@vger.kernel.org X-Gm-Message-State: AFuF++ny3lg4sNroNQInxqGtgilX4dDMo6vF/tIamWru7nFURdJwIJE6 xlV29MoAnQvBthCIbpCltg27fNhdVh3l3LgQ8rWnHoDO9KOfW8LCS9VP X-Gm-Gg: AYBFou3TWz2Wn5mgV35GvptWohWTsOQa4B/f7mgklg8U/7BMxnFOPdPUNx889GsV3cy 303/LxNMGA982q/vdEgdV4D2BMNpQpnpUf66BPYmiXz7/oSIS0xzTZdInJ2FiLhxjZOeJ1QJldn wzAJZDrPFniIND7LmwH0jqEEmFJuKFiL+H3RBbFLLMyxFFC1bi4x+VqxJvHx8JUrvvh5Qtx8rrX tretG2gww4nupVIYxzlf2Do+BRjBP0h1bGV7/MGH32XUVimVZUt66Xi7P+yvJOPx2yroXPZXwx7 JrofiZ4q/AXcJQQqq3sqhlgYmcVbMcjn7TBtt/F4uRAQREUZ0aHbSi+aRj0qbSD51OUUMJ7itnp rU8r8FgzurDsrVPICrc+fYns5u0j3uOowDVv3Dc16z7F5C8BdiG4XvmLiB2MgmbiXxQouRavbMh LYj3x0gJ1dx4lUM+jxZsHsPKQRxHsyHI1Zm1IQE6JXPO4SP9OrDaGqcg2IhbRelyb4HT8ik13xV YcrONKQCTuCc66XGiZDiAMSdfn/D3BG62dxthRaGgdRczOg2O9WjlnevsRLjIhUbJ+fhVvDbMl/ t/T9Mkc7oDw2HcGGE6FG X-Received: by 2002:a05:6808:15a0:b0:4d6:9252:4644 with SMTP id 5614622812f47-4d72ea60fb1mr765056b6e.56.1790202915346; Wed, 23 Sep 2026 15:35:15 -0700 (PDT) Received: from [100.82.231.29] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-491ee1ac486sm559401fac.16.2026.09.23.15.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 15:35:14 -0700 (PDT) From: Jim Cromie Date: Wed, 23 Sep 2026 16:34:40 -0600 Subject: [PATCH v11 16/38] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260923-dd-cmap-part2-clean-v11-16-9b6c217fdf2f@gmail.com> References: <20260923-dd-cmap-part2-clean-v11-0-9b6c217fdf2f@gmail.com> In-Reply-To: <20260923-dd-cmap-part2-clean-v11-0-9b6c217fdf2f@gmail.com> To: Jason Baron , Shuah Khan , Andrew Morton , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Jonathan Corbet , Greg Kroah-Hartman , Nathan Chancellor , Nicolas Schier , Shuah Khan , Randy Dunlap , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Jonathan Corbet , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-pm@vger.kernel.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790202874; l=2921; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=4cPDF74uOTh8cYJJIZjBbCuC9sfRIaYWwiE1nN9E9C0=; b=NdUjfPZHrk8JLNf8jv2A22Pgy2aHnQl1B+XBp+Nta+zkRjS8Vz4S7yx13vlYiDV2b3eubCIw2 aMZRGrTIoLcBlZRhOi8JWmEBIrT337ezVBtIT3C6QaKGDG6HOUEOp6P X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v2: move RvB after SoB --- lib/dynamic_debug.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index bbe32fab74e8..474df0dbedc1 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -620,7 +620,8 @@ static int ddebug_exec_queries(char *query, const char *modname) /* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits, + const unsigned long *new_bits, + const unsigned long old_bits, const char *query_modname) { #define QUERY_SIZE 128 @@ -629,12 +630,12 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, int matches = 0; int bi, ct; - if (*new_bits != *old_bits) + if (*new_bits != old_bits) v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); for (bi = 0; bi < map->length; bi++) { - if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) + if (test_bit(bi, new_bits) == test_bit(bi, &old_bits)) continue; snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], @@ -646,9 +647,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - if (*new_bits != *old_bits) + if (*new_bits != old_bits) v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); return matches; } @@ -690,7 +691,7 @@ static int param_set_dyndbg_module_classes(const char *instr, } old_val = READ_ONCE(*dcp->bits); v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &inrep, &old_val, mod_name); + totct += ddebug_apply_class_bitmap(dcp, &inrep, old_val, mod_name); WRITE_ONCE(*dcp->bits, inrep); break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -704,7 +705,7 @@ static int param_set_dyndbg_module_classes(const char *instr, old_bits = CLASSMAP_BITMASK(old_val); new_bits = CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name); + totct += ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name); WRITE_ONCE(*dcp->lvl, inrep); break; default: -- 2.55.0