From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EAEB475339; Tue, 13 Oct 2026 02:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791858999; cv=none; b=Y3QbrRsgY29pzZf2ys3WSf7axZcWsvNcqBCD85spteF5+xklONMuUkoIximv28qUEeLdAaunWSYTXxnJHa++P6tmcuTRzEtgPUWu0lJkG5N+MrumB8ekEF7J7xJ2eAH7dSH4w3oO7LyILOXlIqq9ASQczBao+zz3f4qWc16WEBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791858999; c=relaxed/simple; bh=AJkKMz3G8EbDnFijjbgXHie4SQNTTzLxICFI8HcxerY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eJnw5YN1ScsukpG6GWf1s84xlBQuPchgsBFo/DIAfG5NaYu8nhrzLalQswdWxTGOfKQjPh7Ec7IwGUVtuVzFIJdU4Qqv3hADedZwV3pkBalEMR78XYy82vdomQWEwoMgTRaGzNw7PF1l8Uo+YUQgsHUbiK4+Z8oc/MOo+0vkz9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pVZ1MK4M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pVZ1MK4M" Received: by smtp.kernel.org (Postfix) with ESMTPS id E11EDC2BD04; Tue, 13 Oct 2026 02:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1791858998; bh=AJkKMz3G8EbDnFijjbgXHie4SQNTTzLxICFI8HcxerY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=pVZ1MK4MLypWpGqK+Eh39y/FCEvBhqbb9mrjiXTwG4Nl1+nDSpz0P5H8RHukRLqO/ 0vbU6vjeRzRNSYL6Nfk9r5X9B0fzXOF+QCXCTk1g7SYLM7tS/YNg3MsEjsz70+TKUz ikySNcEA1BIC6LCS4goF/xd+zjLXH/6e5EpugREDan61qKrcKkUf+m7e+vUBFK06c6 +9jSjZt+GJ8gKsXZThIRVysB1+T+/FPR3iv3AvSX4p7HKewh13ECFHIhnfY1cLgyzo Cv//Ips5xaLQh/tB/QL695Z1nX7Df++80h5yoHo7M3xy4X7rGvYPPWg6yaSQaPCdYN KC54p222Pft4g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5B2CC6B03; Tue, 13 Oct 2026 02:36:38 +0000 (UTC) From: Jim Cromie via B4 Relay Date: Mon, 12 Oct 2026 20:36:46 -0600 Subject: [PATCH v12 15/40] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261012-dd-cmap-part2-clean-v12-15-3c8cc5725def@gmail.com> References: <20261012-dd-cmap-part2-clean-v12-0-3c8cc5725def@gmail.com> In-Reply-To: <20261012-dd-cmap-part2-clean-v12-0-3c8cc5725def@gmail.com> To: Jason Baron , Shuah Khan , Andrew Morton , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Jonathan Corbet , Greg Kroah-Hartman , Nathan Chancellor , Nicolas Schier , Shuah Khan , Randy Dunlap , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Jonathan Corbet , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-pm@vger.kernel.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1791858995; l=2921; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=/ldqEzrdqv/2hMCb93qXE9vZgTc7aNl6mn82Odto4jg=; b=bQIEGw8C2mFiNOEcqjw6elPu/S0GqPmU2GbmeMRsB//9y3HvtzFEfIXY7OLvmOEBR9LOkISXS WR907acdRQGBpW/JO76DuMjemArdVvEl9AYxyTQBE+Bam4tb5WfqIdN X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= X-Endpoint-Received: by B4 Relay for jim.cromie@gmail.com/20260203 with auth_id=958 X-Original-From: Jim Cromie Reply-To: jim.cromie@gmail.com From: Jim Cromie old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v2: move RvB after SoB --- lib/dynamic_debug.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index bbe32fab74e8..474df0dbedc1 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -620,7 +620,8 @@ static int ddebug_exec_queries(char *query, const char *modname) /* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits, + const unsigned long *new_bits, + const unsigned long old_bits, const char *query_modname) { #define QUERY_SIZE 128 @@ -629,12 +630,12 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, int matches = 0; int bi, ct; - if (*new_bits != *old_bits) + if (*new_bits != old_bits) v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); for (bi = 0; bi < map->length; bi++) { - if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) + if (test_bit(bi, new_bits) == test_bit(bi, &old_bits)) continue; snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], @@ -646,9 +647,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - if (*new_bits != *old_bits) + if (*new_bits != old_bits) v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); return matches; } @@ -690,7 +691,7 @@ static int param_set_dyndbg_module_classes(const char *instr, } old_val = READ_ONCE(*dcp->bits); v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &inrep, &old_val, mod_name); + totct += ddebug_apply_class_bitmap(dcp, &inrep, old_val, mod_name); WRITE_ONCE(*dcp->bits, inrep); break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -704,7 +705,7 @@ static int param_set_dyndbg_module_classes(const char *instr, old_bits = CLASSMAP_BITMASK(old_val); new_bits = CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name); + totct += ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name); WRITE_ONCE(*dcp->lvl, inrep); break; default: -- 2.56.0