From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793633531; b=USqGLZPXDA3CfdAUMsRNrSCxTkL/kaqREPft3Jwjtx6QWZ+Xy4byxTSVq/8FLzf4/+SW +i0zrf9cZOQutyzUrTZ3wC5FWoywBAw3LuTYprXQEQrjlFnpMLMmJfB6k9erW/VdhzV+q mm5Hln1h/SHjPymgF9OvcMhkgUWFWXbWQeZnG2v3Bf1+basYtm1M8J71rtrwjNxU4CMv9 y8JAtjg0J92JdF6hJfmTrSJRTqdPrveJQ6TigQ0XxLua3B9y5xryovqypsn0mE1kRJfGj VxHqq9mqi62K76wLumkpTISVduxKXCovQmh/DTM8xoK30Xc2I2Py47EXDQKwD7rXPPA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793633531; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=/ScPPr5h13RwAGNd5LaTn6V2vw4rEmThm0/Me/ibEcc=; b=tKtVKXI8OZO29X3Hlk3QAnRL+xeY8V2tnZvfPP43lboMo2HFFNuwlsIdMj4SF/uMfXHf 7ct984KDAFpGO62Uo2DvWkBiIdHSMuGyUGEt+enKN1zH0EbI2CTYlZOz8RAss36wAP1NH KVE2l7mTgUTLbUBc0AVmrLMI8niqJw2bckiE9EFw6tr6t1SuLahJgR2viNeaf+g7JdLk2 rm/w39JLxRmc7+VGX0hloCbnXnzLvRP+cipjCyXQcp4BKurmOr3BGtMFrNfru+B0KOOIk fgOyMzMLhxludB+HaAy9pfpedHW89hZWRNHzUbDtclB1i9zCFVkswEZNSmgpkRu5cCA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="R/SfkjWl"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D9E260D69A8; Mon, 2 Nov 2026 15:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=R/SfkjWl Received: by smtp.kernel.org (Postfix) with ESMTPSA id 834041F00A17; Mon, 2 Nov 2026 15:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793633529; bh=/ScPPr5h13RwAGNd5LaTn6V2vw4rEmThm0/Me/ibEcc=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=R/SfkjWlo0adylJibXR66wVpuLzM40UvXOuxgQkxjIb27PygVO01Xo6Y9Cxv0DOYF U8vDJ9Lvryykt72BGFLhvtk7I7gcq7QnZbl3EX+DRor36ZfRQHoTy18ofbXZVWub8x loiIMfSMmDrRidXBlhwmW9M/yF25pKJxozll8XYRFV3naaaJjgabiBmeWltQ5KlU4n dqnB3zZZgSK5jXLooPwqv5t5ovJ4Em+lKQ2n3lQJaucJaYsVzo74JlgcgBbH86bHgB 0MidtBYGMNMDITSh0GhFH6xUCs+aKDllisLXlyelzfW76HVNTln7h8X9MMKkJGiQHg RdbysmIcQlqDw== From: Christian Brauner Date: Mon, 02 Nov 2026 16:07:18 +0100 Subject: [PATCH RFC 04/11] netfilter: xt_recent: let procfs own the seq_file X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261102-work-procfs-net-v1-4-982104a4f592@kernel.org> References: <20261102-work-procfs-net-v1-0-982104a4f592@kernel.org> In-Reply-To: <20261102-work-procfs-net-v1-0-982104a4f592@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1502; i=brauner@kernel.org; h=from:subject:message-id; bh=TskCtPEUarxCx4EqZA92+8BIMcoYThcQZwAI90/Y1gc=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWS9WG78b6LTCzn9/5cEdq8IeS3ee1vyt0J0uonutwlHf mXckYq90FHKwiDGxSArpsji0G4SLrecp2KzUaYGzBxWJpAhDFycAjCRHwsYGRryxfz51WWu+Ex4 dvLygrAe7uvesdzsTw4nh8VUHdhTcoKR4UfM5V4bl2lCh997aOft/3BEUfL2u5mz19wX1cw4cIM vnw0A X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Declare the seq_operations and the size of the iterator state and let procfs open and free the seq_file. ->proc_open() only fills in the table now. Reading /proc/net/xt_recent/ then no longer holds up the removal of the table. Signed-off-by: Christian Brauner (Amutable) --- net/netfilter/xt_recent.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c index 11acb9a50d4b..b771cc463aab 100644 --- a/net/netfilter/xt_recent.c +++ b/net/netfilter/xt_recent.c @@ -546,11 +546,7 @@ static const struct seq_operations recent_seq_ops = { static int recent_seq_open(struct inode *inode, struct file *file) { - struct recent_iter_state *st; - - st = __seq_open_private(file, &recent_seq_ops, sizeof(*st)); - if (st == NULL) - return -ENOMEM; + struct recent_iter_state *st = ((struct seq_file *)file->private_data)->private; st->table = pde_data(inode); return 0; @@ -626,11 +622,10 @@ recent_mt_proc_write(struct file *file, const char __user *input, } static const struct proc_ops recent_mt_proc_ops = { + .proc_seq_ops = &recent_seq_ops, + .proc_state_size = sizeof(struct recent_iter_state), .proc_open = recent_seq_open, - .proc_read = seq_read, .proc_write = recent_mt_proc_write, - .proc_release = seq_release_private, - .proc_lseek = seq_lseek, }; static int __net_init recent_proc_net_init(struct net *net) -- 2.53.0