From: Sami Tolvanen <samitolvanen@google.com>
To: Giuliano Procida <gprocida@google.com>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
rust-for-linux@vger.kernel.org,
"Alice Ryhl" <aliceryhl@google.com>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
linux-modules@vger.kernel.org,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Petr Pavlu" <petr.pavlu@suse.com>,
"Daniel Gomez" <da.gomez@kernel.org>,
"Aaron Tomlin" <atomlin@atomlin.com>
Subject: Re: [PATCH v4 0/2] clean up EXPORT_SYMBOL_RUST_GPL
Date: Wed, 4 Nov 2026 01:18:43 +0000 [thread overview]
Message-ID: <20261104011843.GB1247794@google.com> (raw)
In-Reply-To: <20261103165833.418845-1-gprocida@google.com>
Hi Giuliano,
On Tue, Nov 03, 2026 at 04:58:31PM +0000, Giuliano Procida wrote:
> Move EXPORT_SYMBOL_RUST_GPL definitions into linux/export.h and
> prevent the emission of bogus type information for Rust symbols.
>
> Addressing review comments, the first commit now ensures the moves do
> not trigger warnings from scripts/misc-check about missing symbol
> exports by extending regexes to match EXPORT_SYMBOL_RUST_GPL as well.
>
> Giuliano Procida (2):
> rust: move EXPORT_SYMBOL_RUST_GPL to include/linux/export.h
> rust: exports: emit ___EXPORT_SYMBOL without C declarations
>
> drivers/gpu/Makefile | 4 ++--
> drivers/gpu/nova-core/nova_core_exports.c | 5 ++---
> include/linux/export.h | 14 ++++++++++++++
> rust/exports.c | 12 +-----------
> scripts/misc-check | 4 ++--
> 5 files changed, 21 insertions(+), 18 deletions(-)
For the series:
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
As a side note, starting a new thread for each version would make it
easier to navigate the patches in email clients and lore:
https://docs.kernel.org/process/submitting-patches.html#explicit-in-reply-to-headers
Sami
next prev parent reply other threads:[~2026-11-04 1:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261019151243.1595858-1-gprocida@google.com>
2026-10-20 19:22 ` [PATCH] rust: exports: emit ___EXPORT_SYMBOL without C declarations Miguel Ojeda
2026-10-21 9:27 ` Petr Pavlu
2026-10-21 9:44 ` Miguel Ojeda
2026-10-21 14:21 ` Giuliano Procida
2026-10-22 12:42 ` Miguel Ojeda
2026-10-22 13:46 ` [PATCH v2 0/2] clean up EXPORT_SYMBOL_RUST_GPL Giuliano Procida
2026-11-03 12:58 ` [PATCH v3 " Giuliano Procida
2026-11-03 12:58 ` [PATCH v3 1/2] rust: move EXPORT_SYMBOL_RUST_GPL to include/linux/export.h Giuliano Procida
2026-11-03 15:57 ` Petr Pavlu
2026-11-03 16:25 ` Giuliano Procida
2026-11-03 16:58 ` [PATCH v4 0/2] clean up EXPORT_SYMBOL_RUST_GPL Giuliano Procida
2026-11-04 1:18 ` Sami Tolvanen [this message]
2026-11-03 16:58 ` [PATCH v4 1/2] rust: move EXPORT_SYMBOL_RUST_GPL to include/linux/export.h Giuliano Procida
2026-11-03 16:58 ` [PATCH v4 2/2] rust: exports: emit ___EXPORT_SYMBOL without C declarations Giuliano Procida
2026-11-03 12:58 ` [PATCH v3 " Giuliano Procida
2026-10-22 13:46 ` [PATCH v2 1/2] rust: move EXPORT_SYMBOL_RUST_GPL to include/linux/export.h Giuliano Procida
2026-10-22 13:55 ` sashiko-bot
2026-10-22 13:46 ` [PATCH v2 2/2] rust: exports: emit ___EXPORT_SYMBOL without C declarations Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104011843.GB1247794@google.com \
--to=samitolvanen@google.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=atomlin@atomlin.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=da.gomez@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gprocida@google.com \
--cc=linux-modules@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mcgrof@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox