From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.72 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794485721; b=j3VDxQbR2+y7eKX8CNYvHJHhWbRzMLyv7Z2ccw12wpLMdgJEE5sQjPD0w+o2wZb1DTNh eMAPDpjw9rOiCVzoHKnijFYwWzJmr1llu/mX8CxPBT45E9hlPcKceGlGngzs0/rYU81jq kEt0kEAXrbWvhAMz2hFBfzwuhUi5Zz+7BMx4K/5XE/n240nAt6BhgQ82sc5EEhwKMAoFz JLeMdgvHgGj0g+PyIuqcY5GKgtwQnHmzCxSFsm2l0ybpQiPdFYx5rK4Wggyd79wbacAnz z59/1ow9bZn2YmMmwaTLCzcAks7Zb8LYcsrH9fkrJilwlbq054Uzc2JndNHIKEvpjuQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794485721; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=792bh/Up9G16rEbI9KHRJopjEWEttOYtK+WiqlBfpvE=; b=zaQGGLAS6O3SaU6B4RE3NHDnV6hZgevziU7sWdv0e93G0ySVlHLNbATkpD9LNe6e9lck mbp9NZcN+Amyfo/gspAqWMH4EPk3SpJ4brhAjO6m39VmXhLJjdf4k9XIIGwPgpvRp3Kon Em+YP4ec0yjS528tm1z+JWT9ill9IKsAsFwcvfOa0trR+ywpFnigbb171LG6vN/CZOLGG xLj/WN98KHC9uAL5IU3olPafrOIPRbZTPZ8dBIk5nirzM/7K9N9lKuMGwSlpgSkRj7NfL neUcNcY1ieZ0nOQWkUkvFOne80Oc8cJnZ2xRnUAlxyEeJfOTe1urkgfl9sAn3pa9DHQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--gprocida.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=jdgZmgc+; arc=none smtp.remote-ip=209.85.128.72 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2048A606A323 for ; Thu, 12 Nov 2026 12:15:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2048A606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--gprocida.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=jdgZmgc+ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a1f03f2e8aso35691965e9.1 for ; Thu, 12 Nov 2026 04:15:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794485719; x=1795090519; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=792bh/Up9G16rEbI9KHRJopjEWEttOYtK+WiqlBfpvE=; b=jdgZmgc+cFIs1nJDNmHtEbdC7Q0MPUykRgvtyJyqbSmOYZeYTnM3mIoRsyR0ReTv8U cytSWkTuSlVAE6Cojp8xdcrBe0fuzkXg9JlqSlRdJc4sZQveqm5oiPIOXfxoUf04zT4H eTvPAvVyxiHFvj7Xd7GWa3R7T33nA3sqTlobR/eDlve0pNioGwxc6GevCm43/G88DTwK M5IjhrE/plEKd29oAJ2wWy9XaJ2T6x2Kg2wjQEmrUCjRCFLk9dFYEtKljAyNmdwUHzyI emhIEgEbyqjnb2/Lybaom6LpHj0fq5ENVsBOsWlCcnEwPNxcJ0xEOsBZhWlMvmpLnH4Z yqTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794485719; x=1795090519; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=792bh/Up9G16rEbI9KHRJopjEWEttOYtK+WiqlBfpvE=; b=0MkAMBWDKeSpkma/emyK/61Z7V7QhrXqXjJIYcRXVhQRr14QDS/rSIEftufhwebADc ccXMc703eESfdT82My5cZDunZyMjNuKngRIxu2QlucCeZXygJKBDX0+GIMXCX2/zjSZY bFpXOJCcg1xkCKWmkfhbRpNFk7+VDLn6Nn5ctWGG1exWNvnQ6gaHzUqPqwTnaB/KEIcc 36BJWMMXURUaFxki1vAgfjN36k6xI+PstR92n5E+dEKKnmdBK3UmAqkhc2HrjgXsrT6x JZWMW8hqOXAs6QOhuA8pnhW5+rWiXOX4Sb6glP+lHnMddfMGwCX0K6ObPwyWnr7zRxGx lIYg== X-Forwarded-Encrypted: i=1; AL+hErEGMxJVxk9qNYqbFqc7lq2svSw4Z9OuAY1e9BrqckYEDXWNPoxD9/xiQk2pvxp7gqOYFW2AKZ7bHQPriTHN@vger.kernel.org X-Gm-Message-State: APuU4Z8dURz/jl2khDXh1Zi/9he1WeHSyKWbZrcqV8wrNxJkIiAW2ly0 NDKYConobhOCf4rwORMc7RvorFzKXo2Aw02uYapy3cOzPJ9Fo4MSAe48rCJWd6QDs7W5mL7/p6v 5NGPKTUIzPdSgZQ== X-Received: from wmbz23.prod.google.com ([2002:a05:600c:c097:b0:4bb:52ec:7054]) (user=gprocida job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e0e:b0:4a6:eca1:7d5c with SMTP id 5b1f17b1804b1-4ba093ac8f6mr98156255e9.32.1794485719173; Thu, 12 Nov 2026 04:15:19 -0800 (PST) Date: Thu, 12 Nov 2026 12:15:09 +0000 In-Reply-To: <20261112121512.1670347-1-gprocida@google.com> X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261112121512.1670347-1-gprocida@google.com> X-Mailer: git-send-email 2.56.0.567.gdb80ae8cd5-goog Message-ID: <20261112121512.1670347-2-gprocida@google.com> Subject: [PATCH v5 1/4] kbuild: respect skip_gendwarfksyms in cmd_gensymtypes_S From: Giuliano Procida To: Miguel Ojeda Cc: Miguel Ojeda , rust-for-linux@vger.kernel.org, Alice Ryhl , Boqun Feng , Gary Guo , "=?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , "=?UTF-8?q?Onur=20=C3=96zkan?=" , linux-modules@vger.kernel.org, Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Giuliano Procida Content-Type: text/plain; charset="UTF-8" Commit 9c3681f9b9fd ("kbuild: Add gendwarfksyms as an alternative to genksyms") added `skip_gendwarfksyms` handling to `cmd_gensymtypes_c` so that `rust/exports.o` could skip symbol version generation, as CRCs are computed directly from the defining Rust and helper object files. `cmd_gensymtypes_S` is meant to mirror `cmd_gensymtypes_c`, as noted in the comments above both definitions, but omitted the `skip_gendwarfksyms` check. Respect `skip_gendwarfksyms` in `cmd_gensymtypes_S` as well so that `rust/exports.c` can be converted to assembly without `getasmexports` attempting to compile undeclared Rust and helper symbols against `` when `CONFIG_MODVERSIONS` is enabled. Signed-off-by: Giuliano Procida --- scripts/Makefile.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 6127feb970c6..873a9ed62a18 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -428,11 +428,11 @@ getasmexports = \ $(call getexportsymbols,EXPORT_SYMBOL(\1);) ; } ifdef CONFIG_GENDWARFKSYMS -cmd_gensymtypes_S = \ +cmd_gensymtypes_S = $(if $(skip_gendwarfksyms),, \ $(getasmexports) | \ $(CC) $(c_flags) -c -o $(@:.o=.gendwarfksyms.o) -xc -; \ $(call getexportsymbols,\1) | \ - $(gendwarfksyms) $(@:.o=.gendwarfksyms.o) + $(gendwarfksyms) $(@:.o=.gendwarfksyms.o)) else cmd_gensymtypes_S = \ $(getasmexports) | \ -- 2.56.0.567.gdb80ae8cd5-goog