From: David Howells <dhowells@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: dhowells@redhat.com, Lukas Wunner <lukas@wunner.de>,
Ignat Korchagin <ignat@cloudflare.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
Stephan Mueller <smueller@chronox.de>,
linux-crypto@vger.kernel.org, keyrings@vger.kernel.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16 4/7] pkcs7: Allow the signing algo to do whatever digestion it wants itself
Date: Tue, 03 Feb 2026 08:37:32 +0000 [thread overview]
Message-ID: <2546581.1770107852@warthog.procyon.org.uk> (raw)
In-Reply-To: <aYFBbGmMTszT3ZRb@kernel.org>
Jarkko Sakkinen <jarkko@kernel.org> wrote:
> > + if (!sinfo->sig->m_free) {
> > + pr_notice_once("%s: No digest available\n", __func__);
> > + return -EINVAL; /* TODO: MLDSA doesn't necessarily calculate an
> > + * intermediate digest. */
>
> Is this logic going to change in the foreseeable future?
This is only used by IMA to retrieve an intermediate digest, so something will
need to be fixed to support use of ML-DSA in IMA, but I don't know what yet.
It doesn't, however, preclude the use of the rest of the code for module or
kexec signature verification, so I think it's reasonable enough just to emit a
warning and return an error here for now.
David
next prev parent reply other threads:[~2026-02-03 8:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 17:02 [PATCH v16 0/7] x509, pkcs7, crypto: Add ML-DSA signing David Howells
2026-02-02 17:02 ` [PATCH v16 1/7] crypto: Add ML-DSA crypto_sig support David Howells
2026-02-02 17:02 ` [PATCH v16 2/7] x509: Separately calculate sha256 for blacklist David Howells
2026-02-02 17:02 ` [PATCH v16 3/7] pkcs7, x509: Rename ->digest to ->m David Howells
2026-02-02 17:02 ` [PATCH v16 4/7] pkcs7: Allow the signing algo to do whatever digestion it wants itself David Howells
2026-02-03 0:29 ` Jarkko Sakkinen
2026-02-03 8:37 ` David Howells [this message]
2026-02-02 17:02 ` [PATCH v16 5/7] pkcs7, x509: Add ML-DSA support David Howells
2026-02-03 0:30 ` Jarkko Sakkinen
2026-02-02 17:02 ` [PATCH v16 6/7] modsign: Enable ML-DSA module signing David Howells
2026-02-02 17:02 ` [PATCH v16 7/7] pkcs7: Allow authenticatedAttributes for ML-DSA David Howells
2026-02-03 0:35 ` Jarkko Sakkinen
2026-02-05 15:47 ` [PATCH v16 8/7] pkcs7: Change a pr_warn() to pr_warn_once() David Howells
2026-02-08 13:41 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2546581.1770107852@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=da.gomez@kernel.org \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@cloudflare.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox