From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF7B339281D for ; Tue, 3 Feb 2026 08:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770107870; cv=none; b=LhBbcZViN2nK4Lb6ki1HDzP0B641fm4mbSClXMNaq9ZOaDSbBMv38OOg5eYETLiytCrWbYioWfq0qI7QNpDAn0src+8MfBfshE1JTKdNjIvm0Z9Os6kSssHpg3LT8UdqTJfkjjmdedYO4920l2Rmmw7qLhklbMDwUagLn2vJelY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770107870; c=relaxed/simple; bh=fhHFRlG3WCN2W/+rRzgUganS8d2ZUMiekULHR4bbk1U=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=cEvQVrVbK8+gEN+e1p89rE1+w4wXQnoECFVGILaltLeTqgiJ+usb17g8SPypXFqb9IlY8jWeMS4CD44jUHe0JgHfBfZsHt0Q6skZlo1rQrZNsvtJ09jkJ2M6CXi8Kr7L39r7V7ntSHCBrMG/tbfQkosl3MntVIIjolWvmgAHaL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JAXEFd/M; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JAXEFd/M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770107868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t011cPPxfFjL7A/dPlf694kTW9GQnC1PCROS07B/K/U=; b=JAXEFd/MfktRMsrK5dHBOVyRUB7LxCZTer7d6U99ZubIQsEDWAgOAwKL4X4hAFNpJWXoWt ZYxP+2u33HTD/3KqMxG3ECuwPGT5O7cBi66ugugNc6WqvG43NXN9d33g4fCv03nGp5TEl5 m7ubjevdFKo1O9G/1iDok1HjOUNHLF0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-SBygyrJcOJKcJ7bPyQoI7Q-1; Tue, 03 Feb 2026 03:37:42 -0500 X-MC-Unique: SBygyrJcOJKcJ7bPyQoI7Q-1 X-Mimecast-MFC-AGG-ID: SBygyrJcOJKcJ7bPyQoI7Q_1770107860 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 304C6195608F; Tue, 3 Feb 2026 08:37:39 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.33.164]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1F71D30001A7; Tue, 3 Feb 2026 08:37:33 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20260202170216.2467036-1-dhowells@redhat.com> <20260202170216.2467036-5-dhowells@redhat.com> To: Jarkko Sakkinen Cc: dhowells@redhat.com, Lukas Wunner , Ignat Korchagin , Herbert Xu , Eric Biggers , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , "Jason A . Donenfeld" , Ard Biesheuvel , Stephan Mueller , linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 4/7] pkcs7: Allow the signing algo to do whatever digestion it wants itself Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2546580.1770107852.1@warthog.procyon.org.uk> Date: Tue, 03 Feb 2026 08:37:32 +0000 Message-ID: <2546581.1770107852@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Jarkko Sakkinen wrote: > > + if (!sinfo->sig->m_free) { > > + pr_notice_once("%s: No digest available\n", __func__); > > + return -EINVAL; /* TODO: MLDSA doesn't necessarily calculate an > > + * intermediate digest. */ > > Is this logic going to change in the foreseeable future? This is only used by IMA to retrieve an intermediate digest, so something will need to be fixed to support use of ML-DSA in IMA, but I don't know what yet. It doesn't, however, preclude the use of the rest of the code for module or kexec signature verification, so I think it's reasonable enough just to emit a warning and return an error here for now. David