public inbox for linux-modules@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, Lukas Wunner <lukas@wunner.de>,
	Ignat Korchagin <ignat@cloudflare.com>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Eric Biggers <ebiggers@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Stephan Mueller <smueller@chronox.de>,
	linux-crypto@vger.kernel.org, keyrings@vger.kernel.org,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [GIT PULL] x509, pkcs7: Add support for ML-DSA signatures
Date: Fri, 06 Feb 2026 13:33:26 +0000	[thread overview]
Message-ID: <2977832.1770384806@warthog.procyon.org.uk> (raw)

Hi Linus,

Could you pull this patchset in the upcoming merge window please?  It adds
support for ML-DSA signatures in X.509 certificates and PKCS#7/CMS
messages, thereby allowing this algorithm to be used for signing modules,
kexec'able binaries, wifi regulatory data, etc..

This requires OpenSSL-3.5 at a minimum and preferably OpenSSL-4 (so that it
can avoid the use of CMS signedAttrs - but that version is not cut yet).
certs/Kconfig does a check to hide the signing options if OpenSSL does not
list the algorithm as being available.

Note that this is dependent on Eric Bigger's libcrypto (for the core ML-DSA
implementation) and would need to be pulled after that.

Note also that this has a conflict with the modules tree which has a patch
to unconditionally use the OpenSSL CMS_* API to generate signatures in
scripts/sign-file.c and to remove fallback use of the PKCS7_* API.  I've
added an illustrative merge at the top of my keys-pqc branch for reference
purposes.

The patches were last posted here:

	https://lore.kernel.org/r/20260202170216.2467036-1-dhowells@redhat.com/

Thanks,
David
---
The following changes since commit 959a634ebcda02e0add101024a5793323d66cda5:

  lib/crypto: mldsa: Add FIPS cryptographic algorithm self-test (2026-01-12 11:07:50 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/keys-next-20260206

for you to fetch changes up to 965e9a2cf23b066d8bdeb690dff9cd7089c5f667:

  pkcs7: Change a pr_warn() to pr_warn_once() (2026-02-05 15:44:00 +0000)

----------------------------------------------------------------
keys: Support for ML-DSA module signing

----------------------------------------------------------------
David Howells (8):
      crypto: Add ML-DSA crypto_sig support
      x509: Separately calculate sha256 for blacklist
      pkcs7, x509: Rename ->digest to ->m
      pkcs7: Allow the signing algo to do whatever digestion it wants itself
      pkcs7, x509: Add ML-DSA support
      modsign: Enable ML-DSA module signing
      pkcs7: Allow authenticatedAttributes for ML-DSA
      pkcs7: Change a pr_warn() to pr_warn_once()

 Documentation/admin-guide/module-signing.rst |  16 ++-
 certs/Kconfig                                |  40 ++++++
 certs/Makefile                               |   3 +
 crypto/Kconfig                               |   9 ++
 crypto/Makefile                              |   2 +
 crypto/asymmetric_keys/Kconfig               |  11 ++
 crypto/asymmetric_keys/asymmetric_type.c     |   4 +-
 crypto/asymmetric_keys/pkcs7_parser.c        |  36 ++++-
 crypto/asymmetric_keys/pkcs7_parser.h        |   3 +
 crypto/asymmetric_keys/pkcs7_verify.c        |  78 +++++++----
 crypto/asymmetric_keys/public_key.c          |  13 +-
 crypto/asymmetric_keys/signature.c           |   3 +-
 crypto/asymmetric_keys/x509_cert_parser.c    |  27 +++-
 crypto/asymmetric_keys/x509_parser.h         |   2 +
 crypto/asymmetric_keys/x509_public_key.c     |  42 ++++--
 crypto/mldsa.c                               | 201 +++++++++++++++++++++++++++
 include/crypto/public_key.h                  |   6 +-
 include/linux/oid_registry.h                 |   5 +
 scripts/sign-file.c                          |  39 ++++--
 security/integrity/digsig_asymmetric.c       |   4 +-
 20 files changed, 473 insertions(+), 71 deletions(-)
 create mode 100644 crypto/mldsa.c


             reply	other threads:[~2026-02-06 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 13:33 David Howells [this message]
2026-02-10 18:10 ` [GIT PULL] x509, pkcs7: Add support for ML-DSA signatures pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2977832.1770384806@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=da.gomez@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@cloudflare.com \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mcgrof@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=smueller@chronox.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox