From: Petr Pavlu <petr.pavlu@suse.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>,
mcgrof@kernel.org, da.gomez@kernel.org, atomlin@atomlin.com,
linux-modules@vger.kernel.org
Subject: Re: [PATCH v2] module: procfs: fix signed integer overflow in module_total_size()
Date: Fri, 10 Jul 2026 09:36:55 +0200 [thread overview]
Message-ID: <42fc10b8-1d75-409a-b57c-e778930c6186@suse.com> (raw)
In-Reply-To: <CABCJKuczwBmtKXiyzh31Efwbt6VfwUpStLPjXkUFNHwwSPQA5g@mail.gmail.com>
On 7/9/26 5:25 PM, Sami Tolvanen wrote:
> On Thu, Jul 9, 2026 at 1:45 AM Petr Pavlu <petr.pavlu@suse.com> wrote:
>>
>> On 6/7/26 6:18 AM, Naveen Kumar Chaudhary wrote:
>>> module_total_size() returns unsigned int but uses a signed int
>>> accumulator. While the result is numerically correct, the type
>>> mismatch is misleading.
>>>
>>> Change the accumulator to unsigned int to match the return type.
>>>
>>> Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>
>>
>> Queued on modules-next for v7.3-rc1.
>
> Note that the commit title still claims to fix a signed integer
> overflow, which isn't accurate. Otherwise LGTM.
Thanks for noticing this. I tweaked the title to:
module: procfs: use matching type for accumulator in module_total_size()
-- Petr
prev parent reply other threads:[~2026-07-10 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 16:24 [PATCH] module: procfs: fix signed integer overflow in module_total_size() Naveen Kumar Chaudhary
2026-06-05 20:52 ` Sami Tolvanen
2026-06-07 4:18 ` [PATCH v2] " Naveen Kumar Chaudhary
2026-07-09 8:45 ` Petr Pavlu
2026-07-09 15:25 ` Sami Tolvanen
2026-07-10 7:36 ` Petr Pavlu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42fc10b8-1d75-409a-b57c-e778930c6186@suse.com \
--to=petr.pavlu@suse.com \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=naveen.osdev@gmail.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox