linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kbuild: add target to install gzipped modules
Date: Thu, 29 Dec 2011 17:42:26 +0100	[thread overview]
Message-ID: <4EFC9872.7000708@suse.cz> (raw)
In-Reply-To: <1325173819-26274-1-git-send-email-lucas.demarchi@profusion.mobi>

Dne 29.12.2011 16:50, Lucas De Marchi napsal(a):
> Add target in Makefile to compress the module after it's installed.
> Module-init-tools and libkmod can handle gzipped modules.

I am not convinced that this is a needed feature. Compressing elf files
means that depmod and modinfo need to read the whole compressed file
from disk and unpack it, while only a couple of bytes need to be read.
Those concerned about disk space either compile only the few needed
modules and/or use some compressed filesystem, which allows for random
access.


> This is not much useful for distributions because the package will gzip
> the modules and call depmod in a install rule. However for those
> compiling the kernel on their own and debugging module loading, it's
> useful so depmod doesn't have to be called twice and we don't have to
> manually compress the modules.

I understand that you need *.ko.gz support in kmod for the sake of
feature parity and that such patch would help you with debugging. But I
doubt there is use for it apart of developing kmod. Wouldn't an external
script like this do the same job for you?

#!/bin/sh
make "$@" modules_install
rel="$(make -s "$@" kernelrelease)"
find "/lib/modules/$rel" -name '*.ko' -exec gzip '{}' ';'
depmod "$rel"

Michal

  parent reply	other threads:[~2011-12-29 16:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-29 15:50 [PATCH 1/2] kbuild: add target to install gzipped modules Lucas De Marchi
2011-12-29 15:50 ` [PATCH 2/2] kbuild: add target to install xz modules Lucas De Marchi
2011-12-29 16:42 ` Michal Marek [this message]
2011-12-29 16:55   ` [PATCH 1/2] kbuild: add target to install gzipped modules Lucas De Marchi
2011-12-29 17:05     ` Michal Marek
2011-12-29 17:35   ` Lucas De Marchi
2011-12-30 10:30     ` Michal Marek
2011-12-30 14:07       ` Lucas De Marchi
2011-12-29 17:21 ` Dave Jones
2011-12-30 10:23   ` Michal Marek
2011-12-30 15:37     ` Dave Jones
2011-12-30 16:40       ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EFC9872.7000708@suse.cz \
    --to=mmarek@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).