From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sgw@linux.intel.com>
Message-ID: <5255F73C.6050908@linux.intel.com>
Date: Wed, 09 Oct 2013 17:39:24 -0700
From: Saul Wold <sgw@linux.intel.com>
MIME-Version: 1.0
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
CC: linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH] Makefile.am: add mkdir testsuite and standaline build
 target
References: <1381359227-29867-1-git-send-email-sgw@linux.intel.com> <CAKi4VALxoEXMu5DQBZbX9ckGCtSX6-EF7ehnLtLPxF9PumUE+g@mail.gmail.com>
In-Reply-To: <CAKi4VALxoEXMu5DQBZbX9ckGCtSX6-EF7ehnLtLPxF9PumUE+g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
List-ID: <linux-modules.vger.kernel.org>

On 10/09/2013 04:30 PM, Lucas De Marchi wrote:
> Hi Saul,
>
> On Wed, Oct 9, 2013 at 7:53 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> If we are not building in the existing source tree, the testsuite
>> directory will not exist so the cp of the stamp-rootfs would fail.
>>
>> Also added buildtest-TESTS so they could be build in the cross env,
>> without running the tests.
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>   Makefile.am | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index c165868..018e6ed 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -131,7 +131,7 @@ endif
>>
>>   ROOTFS = testsuite/rootfs
>>   ROOTFS_PRISTINE = $(top_srcdir)/testsuite/rootfs-pristine
>> -CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && \
>> +CREATE_ROOTFS = $(AM_V_GEN) ( $(RM) -rf $(ROOTFS) && mkdir -p $(dir $(ROOTFS)) && \
>
> I think it's something else that's causing a failure for you.  The
> following works for me:
>
> $ ./autogen.sh
> $ cd /tmp/build
> $ $OLDPWD/configure --sysconfdir=/etc --with-zlib && make -j10 check
>
> You really need the --sysconfdir=/etc and --with-zlib otherwise some
> tests will fail.  These are the flags we pass to distcheck, that also
> builds out of tree (but in an inner directory)
>
Since I am not running check on the build machine, I am running check on 
the target, I create an installable package that includes the rootfs and 
tests, to this I run make rootfs on the build machine, can you veify 
that that works in a clean build directory?

Since the make check above will create the testsuite directory and build 
all the tests before rootfs target is called, in my case that does not 
happen.


>>                                  cp -r $(ROOTFS_PRISTINE) $(ROOTFS) && \
>>                                  touch testsuite/stamp-rootfs && \
>>                                  find $(ROOTFS) -type d -exec chmod +w {} \; )
>> @@ -217,6 +217,9 @@ DISTCHECK_CONFIGURE_FLAGS=--enable-gtk-doc --sysconfdir=/etc --with-zlib
>>
>>   distclean-local: $(DISTCLEAN_LOCAL_HOOKS)
>>
>> +buildtest-TESTS:
>> +       $(MAKE) $(AM_MAKEFLAGS) $(check_LTLIBRARIES) $(check_PROGRAMS)
>> +
>
> Makes sense. Splitting the patch would be good.
>

Do you still want this split based on the above observation?

Sau!
> Thanks
> Lucas De Marchi
>