From: Michal Marek <mmarek@suse.cz>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH] libkmod-config: Only match dot before '=' in /proc/cmdline
Date: Thu, 06 Mar 2014 18:00:46 +0100 [thread overview]
Message-ID: <5318A9BE.1060401@suse.cz> (raw)
In-Reply-To: <CAKi4VALsNKSABf6Umi1VP-27zGDCEcHjogPwiq3b4AJMcLs3ww@mail.gmail.com>
On 2014-03-06 15:03, Lucas De Marchi wrote:
> Hi,
>
> On Wed, Mar 5, 2014 at 12:30 PM, Lucas De Marchi
> <lucas.de.marchi@gmail.com> wrote:
>> Hi,
>>
>> On Wed, Mar 5, 2014 at 9:27 AM, Michal Marek <mmarek@suse.cz> wrote:
>>> Otherwise, we also parse strings like
>>>
>>> BOOT_IMAGE=/boot/vmlinuz-3.12.12-57.g5f654cf-default
>>>
>>> In practice, this is not a problem, because there is no module named
>>> BOOT_IMAGE=/boot/vmlinuz-3. It just disturbs in modprobe -c output.
>>> ---
>>
>> Applied.
>>
>> Since you already touched the testsuite in previous patches, could you
>> add tests for these, too?
>
> So... I went ahead and added some tests that I'm sending to the ML.
> could you take a look?
Thanks, I will have a look later. I was chasing another testsuite bug
this afternoon. Will send the patch soon.
Michal
prev parent reply other threads:[~2014-03-06 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 12:27 [PATCH] libkmod-config: Only match dot before '=' in /proc/cmdline Michal Marek
2014-03-05 15:30 ` Lucas De Marchi
2014-03-06 14:03 ` Lucas De Marchi
2014-03-06 17:00 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318A9BE.1060401@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).