From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5318A9BE.1060401@suse.cz> Date: Thu, 06 Mar 2014 18:00:46 +0100 From: Michal Marek MIME-Version: 1.0 To: Lucas De Marchi CC: linux-modules Subject: Re: [PATCH] libkmod-config: Only match dot before '=' in /proc/cmdline References: <1394022461-1657-1-git-send-email-mmarek@suse.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8 List-ID: On 2014-03-06 15:03, Lucas De Marchi wrote: > Hi, > > On Wed, Mar 5, 2014 at 12:30 PM, Lucas De Marchi > wrote: >> Hi, >> >> On Wed, Mar 5, 2014 at 9:27 AM, Michal Marek wrote: >>> Otherwise, we also parse strings like >>> >>> BOOT_IMAGE=/boot/vmlinuz-3.12.12-57.g5f654cf-default >>> >>> In practice, this is not a problem, because there is no module named >>> BOOT_IMAGE=/boot/vmlinuz-3. It just disturbs in modprobe -c output. >>> --- >> >> Applied. >> >> Since you already touched the testsuite in previous patches, could you >> add tests for these, too? > > So... I went ahead and added some tests that I'm sending to the ML. > could you take a look? Thanks, I will have a look later. I was chasing another testsuite bug this afternoon. Will send the patch soon. Michal