From: Michal Marek <mmarek@suse.cz>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>,
linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH 1/3] testsuite: Do not run tests with *.ko.gz if zlib is not enabled
Date: Fri, 04 Apr 2014 12:12:07 +0200 [thread overview]
Message-ID: <533E8577.8050303@suse.cz> (raw)
In-Reply-To: <20140404100622.GB29386@intel.com>
On 2014-04-04 12:06, Lucas De Marchi wrote:
> On Fri, Apr 04, 2014 at 11:59:14AM +0200, Michal Marek wrote:
>> On 2014-04-04 11:47, Lucas De Marchi wrote:
>>> On Fri, Apr 4, 2014 at 6:32 AM, Michal Marek <mmarek@suse.cz> wrote:
>>>> Unfortunately, all the depmod tests depend on zlib.
>>>
>>> wouldn't it be better to decompress these files so we remove the dependencies?
>>
>> I'm not against it. I thought the files were compressed so the the zlib
>> support is tested. I can post a patch that decompresses them.
>
>
> Some of the tests, yes... not all of them. There's 1 specific test for
> compressed modules. The others can be decompressed.
OK, then I will leave test-depmod/modules-order-compressed as is and
uncompress the rest.
Thanks,
Michal
prev parent reply other threads:[~2014-04-04 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 9:32 [PATCH 1/3] testsuite: Do not run tests with *.ko.gz if zlib is not enabled Michal Marek
2014-04-04 9:32 ` [PATCH 2/3] testsuite: Mark empty tests as skipped Michal Marek
2014-04-04 9:32 ` [PATCH 3/3] testsuite: Warn if sysconfdir is not /etc Michal Marek
2014-04-04 9:39 ` [PATCH v2 " Michal Marek
2014-04-04 9:47 ` [PATCH 1/3] testsuite: Do not run tests with *.ko.gz if zlib is not enabled Lucas De Marchi
2014-04-04 9:59 ` Michal Marek
2014-04-04 10:06 ` Lucas De Marchi
2014-04-04 10:12 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533E8577.8050303@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).