* [PATCH] RESEND: add missing O_CLOEXEC in kmod_module_get_size()
@ 2014-06-19 0:51 Cristian Rodríguez
2014-06-19 21:08 ` Lucas De Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Cristian Rodríguez @ 2014-06-19 0:51 UTC (permalink / raw)
To: linux-modules; +Cc: Cristian Rodríguez
---
libkmod/libkmod-module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
index 1d90f34..8046262 100644
--- a/libkmod/libkmod-module.c
+++ b/libkmod/libkmod-module.c
@@ -1781,7 +1781,7 @@ KMOD_EXPORT long kmod_module_get_size(const struct kmod_module *mod)
* loaded.
*/
snprintf(line, sizeof(line), "/sys/module/%s", mod->name);
- dfd = open(line, O_RDONLY);
+ dfd = open(line, O_RDONLY|O_CLOEXEC);
if (dfd < 0)
return -errno;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RESEND: add missing O_CLOEXEC in kmod_module_get_size()
2014-06-19 0:51 [PATCH] RESEND: add missing O_CLOEXEC in kmod_module_get_size() Cristian Rodríguez
@ 2014-06-19 21:08 ` Lucas De Marchi
2014-06-19 21:45 ` Cristian Rodríguez
0 siblings, 1 reply; 3+ messages in thread
From: Lucas De Marchi @ 2014-06-19 21:08 UTC (permalink / raw)
To: Cristian Rodríguez; +Cc: linux-modules
On Wed, Jun 18, 2014 at 9:51 PM, Cristian Rodr=C3=ADguez
<crrodriguez@opensuse.org> wrote:
> ---
> libkmod/libkmod-module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
> index 1d90f34..8046262 100644
> --- a/libkmod/libkmod-module.c
> +++ b/libkmod/libkmod-module.c
> @@ -1781,7 +1781,7 @@ KMOD_EXPORT long kmod_module_get_size(const struct =
kmod_module *mod)
> * loaded.
> */
> snprintf(line, sizeof(line), "/sys/module/%s", mod->name);
> - dfd =3D open(line, O_RDONLY);
> + dfd =3D open(line, O_RDONLY|O_CLOEXEC);
> if (dfd < 0)
> return -errno;
>
> --
I don't know what's the RESEND in the subject, but the patch looks
good. I removed it and applied.
Thanks.
--=20
Lucas De Marchi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RESEND: add missing O_CLOEXEC in kmod_module_get_size()
2014-06-19 21:08 ` Lucas De Marchi
@ 2014-06-19 21:45 ` Cristian Rodríguez
0 siblings, 0 replies; 3+ messages in thread
From: Cristian Rodríguez @ 2014-06-19 21:45 UTC (permalink / raw)
To: linux-modules; +Cc: linux-modules
El jue 19 jun 2014 17:08:21 CLT, Lucas De Marchi escribió:
> On Wed, Jun 18, 2014 at 9:51 PM, Cristian Rodríguez
> <crrodriguez@opensuse.org> wrote:
>> ---
>> libkmod/libkmod-module.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
>> index 1d90f34..8046262 100644
>> --- a/libkmod/libkmod-module.c
>> +++ b/libkmod/libkmod-module.c
>> @@ -1781,7 +1781,7 @@ KMOD_EXPORT long kmod_module_get_size(const struct kmod_module *mod)
>> * loaded.
>> */
>> snprintf(line, sizeof(line), "/sys/module/%s", mod->name);
>> - dfd = open(line, O_RDONLY);
>> + dfd = open(line, O_RDONLY|O_CLOEXEC);
>> if (dfd < 0)
>> return -errno;
>>
>> --
>
> I don't know what's the RESEND in the subject, but the patch looks
> good. I removed it and applied.
>
> Thanks.
>
That means I sent it before months ago but didn't get an answer and/or
it applied.
--
Cristian
"I don't know the key to success, but the key to failure is trying to
please everybody."
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-19 21:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-19 0:51 [PATCH] RESEND: add missing O_CLOEXEC in kmod_module_get_size() Cristian Rodríguez
2014-06-19 21:08 ` Lucas De Marchi
2014-06-19 21:45 ` Cristian Rodríguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).