From: Laura Abbott <labbott@redhat.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>,
Laura Abbott <labbott@fedoraproject.org>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH 4/4] depmod: Add error message for bad version
Date: Fri, 18 Sep 2015 11:30:25 -0700 [thread overview]
Message-ID: <55FC5841.1080501@redhat.com> (raw)
In-Reply-To: <CAKi4VAJiG3con6bcK5OkaBuFaeh19eyfUszE34Nt5e_Z2dYs5g@mail.gmail.com>
On 09/12/2015 12:00 PM, Lucas De Marchi wrote:
> On Fri, Sep 11, 2015 at 5:55 PM, Laura Abbott <labbott@fedoraproject.org> wrote:
>>
>> Currently, if a value that doesn't match a kernel version
>> ("%u.%u") is passed in, depmod silently falls back to
>> using uname. Make it clear to the user that this is happening
>> by giving a message to the user.
>> ---
>
> Actually I think we should not fallback. If the user passed a wrong
> number, fallbacking to the currently running kernel is plain wrong.
> This was done mostly due to compatibility with module-init-tools but I
> prefer breaking it rather than silently (or verbose as per your patch)
> doing the wrong thing.
>
Sounds fine to me if you are okay with the breakage.
Thanks,
Laura
next prev parent reply other threads:[~2015-09-18 18:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 20:55 [PATCH 0/4] depmod and modprobe error message fixups Laura Abbott
2015-09-11 20:55 ` [PATCH 1/4] build: Properly check for Cython Laura Abbott
2015-09-12 18:27 ` Lucas De Marchi
2015-09-18 17:38 ` Laura Abbott
2015-09-24 1:11 ` Lucas De Marchi
2015-09-11 20:55 ` [PATCH 2/4] modprobe: Add appropriate error message when path is missing Laura Abbott
2015-09-12 18:45 ` Lucas De Marchi
2015-09-11 20:55 ` [PATCH 3/4] depmod: Fix message printing before log_setup_kmod_log Laura Abbott
2015-09-12 18:55 ` Lucas De Marchi
2015-09-18 18:26 ` Laura Abbott
2015-09-24 1:16 ` Lucas De Marchi
2015-09-11 20:55 ` [PATCH 4/4] depmod: Add error message for bad version Laura Abbott
2015-09-12 19:00 ` Lucas De Marchi
2015-09-18 18:30 ` Laura Abbott [this message]
2015-09-24 1:17 ` Lucas De Marchi
2015-09-12 19:05 ` [PATCH 0/4] depmod and modprobe error message fixups Lucas De Marchi
2015-09-16 23:35 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC5841.1080501@redhat.com \
--to=labbott@redhat.com \
--cc=labbott@fedoraproject.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).