From: Philippe De Swert <philippedeswert@gmail.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH] insmod: do support -f
Date: Fri, 16 Oct 2015 15:04:26 +0300 [thread overview]
Message-ID: <5620E7CA.3020509@gmail.com> (raw)
In-Reply-To: <CAKi4VAKvhn53jSHju9_wbXtt_Unhpxayf3ayKq5endOG4LzxDw@mail.gmail.com>
Hi Lucas,
On 11/10/15 21:59, Lucas De Marchi wrote:
> Hi Pom: Philippe De Swert <philippe.deswert@jollamobile.com>
>
> The -f switch is accepted by insmod, but silently ignored. This
> causes the user to wonder why things don't work. As insmod is
> most often used with "evil" modules, -f is almost default and
> thus needs to work.
> I'd encourage people for actually *not* using -f.
Well unfortunately we still do not live in a perfect world yet. Reality
is that I had to yet again
deal with a mystery module from the deep...
> I have mixed feelings here because this is disabled in insmod since
> forever (it's already on the first git commit from module-init-tools).
> If anyone knows the reason it would be nice... at least to include in
> the commit message.
Well the weirdest thing is that it is ignored without warning. With as a
result it lets you wonder why it
did not work. I wasted quite some time checking if the last -f fix
actually did what it was supposed to do.
As making -f work was not that hard I quickly did it. Another option
would at least let the user of it know
that it won't work. However imho insmod -f is the first command you will
use trying to insert a mystery module
as it will most likely also not be visible to modprobe as the location
of it can be arbitrary.
Regards,
Philippe
next prev parent reply other threads:[~2015-10-16 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 15:36 [PATCH] insmod: do support -f philippedeswert
2015-10-11 18:59 ` Lucas De Marchi
2015-10-16 12:04 ` Philippe De Swert [this message]
2015-10-25 15:58 ` Lucas De Marchi
2015-10-26 10:28 ` Philippe De Swert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620E7CA.3020509@gmail.com \
--to=philippedeswert@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).