From: Petr Pavlu <petr.pavlu@suse.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 0/6] module: sysfs: Cleanups and preparation for const struct bin_attribute
Date: Tue, 31 Dec 2024 16:07:40 +0100 [thread overview]
Message-ID: <6f2d2843-e676-4d4a-86aa-881378b1adf1@suse.com> (raw)
In-Reply-To: <20241227-sysfs-const-bin_attr-module-v2-0-e267275f0f37@weissschuh.net>
On 12/27/24 14:23, Thomas Weißschuh wrote:
> The sysfs core is switching to 'const struct bin_attribute's.
> Prepare for that.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Changes in v2:
> - Avoid NULL-deref in free_sect_attrs()
> - Avoid double-free and NULL-deref in free_notes_attrs()
> - Also drop 'struct module_sect_attr'
> - Link to v1: https://lore.kernel.org/r/20241216-sysfs-const-bin_attr-module-v1-0-f81e49e54ce4@weissschuh.net
>
> ---
> Thomas Weißschuh (6):
> module: sysfs: Drop member 'module_sect_attrs::nsections'
> module: sysfs: Drop member 'module_sect_attr::address'
> module: sysfs: Drop 'struct module_sect_attr'
> module: sysfs: Simplify section attribute allocation
> module: sysfs: Add notes attributes through attribute_group
> module: sysfs: Use const 'struct bin_attribute'
>
> kernel/module/sysfs.c | 116 ++++++++++++++++++++++++--------------------------
> 1 file changed, 55 insertions(+), 61 deletions(-)
> ---
> base-commit: d6ef8b40d075c425f548002d2f35ae3f06e9cf96
> change-id: 20241215-sysfs-const-bin_attr-module-be05346937a6
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
I'm going to wait for a few days if others want to comment and then plan
to queue this on the modules tree for the 6.14 merge window.
--
Thanks,
Petr
next prev parent reply other threads:[~2024-12-31 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 13:23 [PATCH v2 0/6] module: sysfs: Cleanups and preparation for const struct bin_attribute Thomas Weißschuh
2024-12-27 13:23 ` [PATCH v2 1/6] module: sysfs: Drop member 'module_sect_attrs::nsections' Thomas Weißschuh
2024-12-27 13:23 ` [PATCH v2 2/6] module: sysfs: Drop member 'module_sect_attr::address' Thomas Weißschuh
2024-12-27 13:23 ` [PATCH v2 3/6] module: sysfs: Drop 'struct module_sect_attr' Thomas Weißschuh
2024-12-27 13:23 ` [PATCH v2 4/6] module: sysfs: Simplify section attribute allocation Thomas Weißschuh
2024-12-27 13:23 ` [PATCH v2 5/6] module: sysfs: Add notes attributes through attribute_group Thomas Weißschuh
2024-12-27 13:23 ` [PATCH v2 6/6] module: sysfs: Use const 'struct bin_attribute' Thomas Weißschuh
2024-12-31 15:07 ` Petr Pavlu [this message]
2025-01-07 16:52 ` [PATCH v2 0/6] module: sysfs: Cleanups and preparation for const struct bin_attribute Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f2d2843-e676-4d4a-86aa-881378b1adf1@suse.com \
--to=petr.pavlu@suse.com \
--cc=da.gomez@samsung.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox