From: Nick Alcock <nick.alcock@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Adam Ford <aford173@gmail.com>
Subject: Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
Date: Mon, 20 Mar 2023 11:08:35 +0000 [thread overview]
Message-ID: <877cvbu1cc.fsf@esperi.org.uk> (raw)
In-Reply-To: <CAMuHMdUFePvbBk7ELH3s8QrTiqEoC0xwQN_YCr9brSaFede-ig@mail.gmail.com> (Geert Uytterhoeven's message of "Tue, 28 Feb 2023 14:45:51 +0100")
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> Hi Nick,
>
> On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>>
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Thanks for your patch!
>
>> drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
>
> I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
> tristate. Shimoda-san?
This patch touches three files, so I hope that means the MODULE_LICENSE
removal from drivers/clk/renesas/renesas-cpg-mssr.c and
drivers/clk/renesas/rzg2l-cpg.c is OK :)
next prev parent reply other threads:[~2023-03-20 11:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:01 ` [PATCH 01/20] perf/hw_breakpoint: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-28 13:01 ` [PATCH 02/20] pinctrl: amd: " Nick Alcock
2023-03-07 13:08 ` Linus Walleij
2023-02-28 13:01 ` [PATCH 03/20] pinctrl: mediatek: " Nick Alcock
2023-02-28 13:01 ` [PATCH 04/20] pinctrl: renesas: " Nick Alcock
2023-02-28 13:02 ` [PATCH 05/20] lib: " Nick Alcock
2023-02-28 16:35 ` Keller, Jacob E
2023-02-28 13:02 ` [PATCH 06/20] powercap: " Nick Alcock
2023-02-28 20:33 ` Rafael J. Wysocki
2023-02-28 13:02 ` [PATCH 07/20] power: supply: " Nick Alcock
2023-02-28 13:02 ` [PATCH 08/20] remoteproc: " Nick Alcock
2023-02-28 13:35 ` Mukesh Ojha
2023-03-02 22:01 ` Mathieu Poirier
2023-02-28 13:02 ` [PATCH 09/20] clk: renesas: " Nick Alcock
2023-02-28 13:45 ` Geert Uytterhoeven
2023-02-28 14:07 ` Adam Ford
2023-03-20 11:08 ` Nick Alcock [this message]
2023-02-28 13:02 ` [PATCH 10/20] reset: mchp: sparx5: " Nick Alcock
2023-02-28 14:53 ` Steen Hegelund
2023-02-28 13:02 ` [PATCH 11/20] reset: lantiq: " Nick Alcock
2023-02-28 13:02 ` [PATCH 12/20] clk: microchip: mpfs: " Nick Alcock
2023-02-28 19:19 ` Conor Dooley
2023-02-28 13:02 ` [PATCH 13/20] reset: " Nick Alcock
2023-02-28 19:17 ` Conor Dooley
2023-02-28 19:26 ` Nick Alcock
2023-02-28 19:53 ` Conor Dooley
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: " Nick Alcock
2023-02-28 13:19 ` Daniel Bristot de Oliveira
2023-02-28 13:02 ` [PATCH 15/20] tty: serial: imx: " Nick Alcock
2023-02-28 13:02 ` [PATCH 16/20] irqchip/irq-sl28cpld: " Nick Alcock
2023-02-28 16:12 ` Michael Walle
2023-02-28 13:02 ` [PATCH 17/20] ARC: reset: " Nick Alcock
2023-02-28 13:02 ` [PATCH 18/20] " Nick Alcock
2023-02-28 13:02 ` [PATCH 19/20] power: " Nick Alcock
2023-02-28 13:02 ` [PATCH 20/20] soc/tegra: cbb: " Nick Alcock
2023-04-05 13:09 ` (subset) " Thierry Reding
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
2023-03-20 11:06 ` Nick Alcock
2023-03-09 16:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cvbu1cc.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=aford173@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).