From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26C6E1A304A; Thu, 28 May 2026 13:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779974143; cv=none; b=qd79tEJsbN6S7xyjhAniBUjYEN4cbmXYf2Y2pDXT0GwHE11jZV9MT9AGviLH2MwDEkXgQYs0cosNfXr+VYJXmQsa3j46HKFuP+GXzNW8e/1IeadTa1FCt3JJ4aI7p639p+URdPkoGC7BN1OWj0yLMwZNLWJxpp/53gbjkn3YQdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779974143; c=relaxed/simple; bh=u2oysIY8dHlPzB/hBePgeyZJDrBHmGq0mAa5rmp2OiA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Uv86qImJm3qDOBcAjOq1sOI8etVvPjVhQurkJ3x8cLJ7owqbnO/NY083lVv2z1ATDLZDy22FBfahYD2nGUwUngeyEbXngmjltMoXjS0FEftBr4BD9UblIlgybt2UO0si/AxUXu+LC1lOHaXHMawzPm24B8y7O77QHtYh2BJYSW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NG0Y4rVT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NG0Y4rVT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 366181F000E9; Thu, 28 May 2026 13:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779974141; bh=seqxhQRK94cy6VtY2EuAyzTayFSe+TG9fXYMRDMjo1U=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=NG0Y4rVTtqShVV0xR715sq8CdaMYMiWGXTMD7r55FNgSpEKMbqjKxlyqy+5rNtoqB DJw+kZxm5llzwdMpFdKm7GLqybrEkJJQSZbRHmuikz8B5tiYKH00S9SQ4IIgLzT72r mxkypdnJZ6myTYkhD/9b0T4WaRhU01cb3SrltuuqcwJfOFHW9Ln7lTRn0Kw1DP4ye4 G/PSBG+xrnltxun92SUlG7nFbu43R8Jg8uuZaGV7qsSoEB6teEyKcq1xbzfznV2Flf D8dgvAff4L2l4YaYNP4xKc/U4lTSQf5e/iRVhMXF9hYZSbZfV6bOEZEnQYHkuhiwjY oZ3SKgYCNZCtg== From: Andreas Hindborg To: Greg KH Cc: Wenzhao Liao , mcgrof@kernel.org, petr.pavlu@suse.com, da.gomez@kernel.org, samitolvanen@google.com, ojeda@kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org, atomlin@atomlin.com, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/1] rust: module_param: support bool parameters In-Reply-To: <2026041323-fled-sharply-77c0@gregkh> References: <20260411130254.3510128-1-wenzhaoliao@ruc.edu.cn> <2026041118-croak-serving-ff5e@gregkh> <87fr4zvzn2.fsf@kernel.org> <2026041323-fled-sharply-77c0@gregkh> Date: Thu, 28 May 2026 15:15:28 +0200 Message-ID: <87fr3b7k0f.fsf@t14s.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Greg KH writes: > On Mon, Apr 13, 2026 at 02:00:17PM +0200, Andreas Hindborg wrote: >> "Greg KH" writes: >> >> > On Sat, Apr 11, 2026 at 09:02:53AM -0400, Wenzhao Liao wrote: >> >> Sorry for the earlier noise and for our unfamiliarity with parts of the >> >> kernel submission process, which created extra burden for maintainers. >> >> >> >> This patch adds boolean module parameter support to the Rust `module!` >> >> parameter path. >> >> >> >> It implements `ModuleParam` for `bool` and wires `PARAM_OPS_BOOL` into >> >> the Rust module parameter machinery, so Rust-side parsing reuses the >> >> existing kernel `kstrtobool()` semantics through `kstrtobool_bytes()` >> >> instead of introducing a separate parser. A boolean parameter is also >> >> added to `samples/rust/rust_minimal.rs` as a small reference user and >> >> build-time validation point. >> > >> > What driver needs this feature? Module options should be very rare >> > going forward as they are 1990's technology and do not fit the "modern" >> > kernel model at all. >> >> Rust null block uses module parameters, and was requested to use proper >> boolean parsing rather than overloading u8 parsing for boolean >> parameters [1]. >> >> Best regards, >> Andreas Hindborg >> >> >> [1] https://lore.kernel.org/rust-for-linux/abfK4eji5jKSeO_W@google.com/ >> > > Ok, then that needs to be said somewhere, and ideally, have the code > that uses that as part of the patch series. It should be mentioned for sure, with a link to the code. I'm not sure including this patch in the rnull driver series is the right approach. That series is a really long already. I think using the b4 dependency feature for dependencies is a better approach for marking dependencies. I understand that you want to see APIs in context of use, that makes sense. Best regards, Andreas Hindborg