From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33C592DECC4; Tue, 8 Jul 2025 13:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751980180; cv=none; b=smoam1mrtMws+xfni5vg9b7ogCgvyDwMqUuR7D+s0u2Lyzx6uvqmkHt4ECEbkWx5ugaSGp+OaWjcmvpNFJbhtd0RL6r9I/fsIGCeEcr2ztVaKDQAkTtQ37ZfgRgFgbS/0Hxnjqf40JMUhM1yA0znq3+/N1Y202gClsdsBmudSwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751980180; c=relaxed/simple; bh=em6CDDok4e4eRQnEnKOyatrW3DlF+63ZOcjwUW/BfdE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=m32BIvvCoCWRJ8CZCx6LSGflPwyhTWkpPzEpKsE37fh0Uj5LyeHIjD5y/5Vc2YfxqyG+njZFCLByyrw6Ns5JiGdujnjKIGv2uA8gIpHjox4TnVJpVrdZLauE8eE6mIZJBgmKG0M+/dvBNbPvczJjmL6H3edXRD9ZCLi/ELMemHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qCTT12mR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qCTT12mR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 702BBC4CEED; Tue, 8 Jul 2025 13:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751980179; bh=em6CDDok4e4eRQnEnKOyatrW3DlF+63ZOcjwUW/BfdE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qCTT12mR4V/PgGwYFoDC76R2337Y9C3q6GcSmBVhTjpRpQrumQOy5OEY1UHxRuoBy adfkAYjFztx6o3cNAR6nczyTOSz934aIuh/S01UBIZZiUqDsL6ed8Yt6ccRPDCakw/ Bu721CHtOsPOye2U88XxTuAVhhMFuKoF4DYJYxQd0CrslxOZyiSKWcofklnamKzyeB 5Ti6EQR4925ifjKxZVPknOlKCPz+Am90mNH9KPwYWvKtOSj8VlvBJoGeFqdHwJfe6K CsPja0ASF7R0Xz5Z6oExcq1e284ER1nWEQMiHEDyeDovZue+zLrjn7hxYvwEF19Q6W wy8C/jYttLkKg== From: Andreas Hindborg To: "Miguel Ojeda" Cc: "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , "Alice Ryhl" , "Masahiro Yamada" , "Nathan Chancellor" , "Luis Chamberlain" , "Danilo Krummrich" , "Benno Lossin" , "Nicolas Schier" , "Trevor Gross" , "Adam Bratschi-Kaye" , , , , "Petr Pavlu" , "Sami Tolvanen" , "Daniel Gomez" , "Simona Vetter" , "Greg KH" , "Fiona Behrens" , "Daniel Almeida" , Subject: Re: [PATCH v15 0/7] rust: extend `module!` macro with integer parameter support In-Reply-To: (Miguel Ojeda's message of "Mon, 07 Jul 2025 16:05:56 +0200") References: <20250707-module-params-v3-v15-0-c1f4269a57b9@kernel.org> <1vsVHgS-gcJkvff9ZHVrTNATc83NdHhjpU_wmZI0SBLEGyRqIWQ6abSeg5mirXiji2lnuqJorzjD2ow05c9naA==@protonmail.internalid> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Tue, 08 Jul 2025 15:09:30 +0200 Message-ID: <87pleaomlx.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Miguel Ojeda" writes: > On Mon, Jul 7, 2025 at 3:31=E2=80=AFPM Andreas Hindborg wrote: >> >> Based on code by Adam Bratschi-Kaye lifted from the original `rust` bran= ch [1]. > > I would suggest adding this sort of note to the commit messages, > especially since the commits have no Co-developed-by/Link tags > otherwise. > > From our discussion in Zulip: the code itself is older than that the > merge above. I think you wanted an example sentence for this -- > something simple could be e.g. > > Based on the original module parameter support by Miguel [1], > later extended and generalized by Adam for more types [2][3]. > Originally tracked at [4]. > > Link: https://github.com/Rust-for-Linux/linux/pull/7 [1] > Link: https://github.com/Rust-for-Linux/linux/pull/82 [2] > Link: https://github.com/Rust-for-Linux/linux/pull/87 [3] > Link: https://github.com/Rust-for-Linux/linux/issues/11 [4] > > By the way, I guess you should inherit that issue in the last link :) > It had some details about things we may or may not want to support > etc. that I looked up back then. If you prefer that we close it or > that we create sub-issues, that is fine -- up to you! > > Finally, if you end up adding strings, please link to Adam's > https://github.com/Rust-for-Linux/linux/pull/110. Thanks, I'll add this! Best regards, Andreas Hindborg