From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Adam Bratschi-Kaye" <ark.email@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, "Petr Pavlu" <petr.pavlu@suse.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Daniel Gomez" <da.gomez@samsung.com>,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Fiona Behrens" <me@kloenk.dev>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
linux-modules@vger.kernel.org
Subject: Re: [PATCH v8 5/7] rust: str: add radix prefixed integer parsing functions
Date: Fri, 21 Mar 2025 08:53:59 +0100 [thread overview]
Message-ID: <87zfheddk8.fsf@kernel.org> (raw)
In-Reply-To: <CANiq72kGzB2CdGMcaftfg2eYvu_rBtH2_gxqVt7KE7RQxCgz8Q@mail.gmail.com> (Miguel Ojeda's message of "Thu, 20 Mar 2025 21:21:39 +0100")
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> writes:
> On Thu, Feb 27, 2025 at 3:39 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>> + // SAFETY: We checked that `val` will fit in `Self` above.
>> + let val: Self = unsafe { val.try_into().unwrap_unchecked() };
>
> This is wrong -- `val` can be the maximum, and thus it does not fit
> since it is 2's complement, even if later the complement would.
>
> In fact, it is caught by the doctest when run with debug assertions enabled:
>
> /// assert_eq!(Ok(-128), i8::from_str(b_str!("-128")));
>
> We try to put 128 into `i8`, which of course does not work...
Thanks for catching this! I have to start running tests with debug
assertions, it makes no sense not to do so.
I'll send a new version now, hope it will make the cut.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-03-21 7:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 14:38 [PATCH v8 0/7] rust: extend `module!` macro with integer parameter support Andreas Hindborg
2025-02-27 14:38 ` [PATCH v8 1/7] rust: str: implement `PartialEq` for `BStr` Andreas Hindborg
2025-03-04 11:07 ` Fiona Behrens
2025-02-27 14:38 ` [PATCH v8 2/7] rust: str: implement `Index` " Andreas Hindborg
2025-02-28 9:10 ` Alice Ryhl
2025-02-27 14:38 ` [PATCH v8 3/7] rust: str: implement `AsRef<BStr>` for `[u8]` and `BStr` Andreas Hindborg
2025-03-04 11:09 ` Fiona Behrens
2025-02-27 14:38 ` [PATCH v8 4/7] rust: str: implement `strip_prefix` for `BStr` Andreas Hindborg
2025-02-27 14:38 ` [PATCH v8 5/7] rust: str: add radix prefixed integer parsing functions Andreas Hindborg
2025-03-20 20:21 ` Miguel Ojeda
2025-03-21 7:53 ` Andreas Hindborg [this message]
2025-02-27 14:38 ` [PATCH v8 6/7] rust: add parameter support to the `module!` macro Andreas Hindborg
2025-02-27 14:38 ` [PATCH v8 7/7] modules: add rust modules files to MAINTAINERS Andreas Hindborg
2025-03-20 8:54 ` Daniel Gomez
2025-03-20 8:41 ` [PATCH v8 0/7] rust: extend `module!` macro with integer parameter support Daniel Gomez
2025-03-20 10:26 ` Andreas Hindborg
2025-03-20 12:00 ` Miguel Ojeda
2025-03-20 12:47 ` Petr Pavlu
2025-03-20 23:23 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfheddk8.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=ark.email@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=da.gomez@samsung.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=me@kloenk.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=simona.vetter@ffwll.ch \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).