linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Aaron Tomlin <atomlin@redhat.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: "cl@linux.com" <cl@linux.com>,
	"pmladek@suse.com" <pmladek@suse.com>,
	"mbenes@suse.cz" <mbenes@suse.cz>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"jeyu@kernel.org" <jeyu@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
	"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
	"atomlin@atomlin.com" <atomlin@atomlin.com>,
	"ghalat@redhat.com" <ghalat@redhat.com>,
	"allen.lkml@gmail.com" <allen.lkml@gmail.com>,
	"joe@perches.com" <joe@perches.com>,
	"msuchanek@suse.de" <msuchanek@suse.de>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>
Subject: Re: [PATCH v6 09/13] module: Move kallsyms support into a separate file
Date: Mon, 21 Feb 2022 08:15:32 +0000	[thread overview]
Message-ID: <98cff67e-d2ca-705b-7c83-bd3f41df98d9@csgroup.eu> (raw)
In-Reply-To: <20220218212511.887059-10-atomlin@redhat.com>



Le 18/02/2022 à 22:25, Aaron Tomlin a écrit :
> No functional change.
> 
> This patch migrates kallsyms code out of core module
> code kernel/module/kallsyms.c
> 
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>

With this patch I get an Oops:

[   36.421711] BUG: Unable to handle kernel data access on write at 
0xbe79bb40
[   36.428435] Faulting instruction address: 0xc008b74c
[   36.433342] Oops: Kernel access of bad area, sig: 11 [#1]
[   36.438672] BE PAGE_SIZE=16K PREEMPT CMPC885
[   36.442947] SAF3000 DIE NOTIFICATION
[   36.446421] Modules linked in:
[   36.449436] CPU: 0 PID: 374 Comm: insmod Not tainted 
5.17.0-rc4-s3k-dev-02274-g7d4ec8831803 #1016
[   36.458211] NIP:  c008b74c LR: c00897ac CTR: c001145c
[   36.463200] REGS: caf8bcf0 TRAP: 0300   Not tainted 
(5.17.0-rc4-s3k-dev-02274-g7d4ec8831803)
[   36.471633] MSR:  00009032 <EE,ME,IR,DR,RI>  CR: 24002842  XER: 00000000
[   36.478261] DAR: be79bb40 DSISR: c2000000
[   36.478261] GPR00: c00899a0 caf8bdb0 c230a980 be74c000 caf8beb8 
00000008 00000000 c035629c
[   36.478261] GPR08: be75c000 caf9c9fc be79bb40 00000004 24002842 
100d166a 00000290 00000000
[   36.478261] GPR16: c0747320 caf9c9fc c11ff918 caf9b2a7 be75c290 
00000550 00000022 c0747210
[   36.478261] GPR24: c11ff8e8 be74c000 c11ff8fc 100b8820 00000000 
00000000 be74c000 caf8beb8
[   36.516729] NIP [c008b74c] add_kallsyms+0x48/0x30c
[   36.521465] LR [c00897ac] load_module+0x16f8/0x2504
[   36.526286] Call Trace:
[   36.528693] [caf8bdb0] [00000208] 0x208 (unreliable)
[   36.533598] [caf8bde0] [c00899a0] load_module+0x18ec/0x2504
[   36.539107] [caf8beb0] [c008a7a8] sys_finit_module+0xb4/0xf8
[   36.544700] [caf8bf30] [c00120a4] ret_from_syscall+0x0/0x28
[   36.550209] --- interrupt: c00 at 0xfd5e7c0
[   36.554339] NIP:  0fd5e7c0 LR: 100144e8 CTR: 10013238
[   36.559331] REGS: caf8bf40 TRAP: 0c00   Not tainted 
(5.17.0-rc4-s3k-dev-02274-g7d4ec8831803)
[   36.567763] MSR:  0000d032 <EE,PR,ME,IR,DR,RI>  CR: 24002222  XER: 
00000000
[   36.574735]
[   36.574735] GPR00: 00000161 7fc5a130 7792f4e0 00000003 100b8820 
00000000 0fd4ded4 0000d032
[   36.574735] GPR08: 00000000 10013238 00000000 00000002 142d2297 
100d166a 100a0920 00000000
[   36.574735] GPR16: 100cac0c 100b0000 1013c3cc 1013d685 100d0000 
100d0000 00000000 100a0900
[   36.574735] GPR24: ffffffa2 ffffffff 1013c3a4 00000003 1013c3cc 
100b8820 1013c3f0 1013c3cc
[   36.610535] NIP [0fd5e7c0] 0xfd5e7c0
[   36.614065] LR [100144e8] 0x100144e8
[   36.617593] --- interrupt: c00
[   36.620609] Instruction dump:
[   36.623534] 7c7e1b78 81040038 8124003c 81430100 55082036 7d0a4214 
1d490028 81240010
[   36.631365] 9103015c 7d295214 8109000c 8143015c <910a0000> 81290014 
8143015c 5529e13e
[   36.639376] ---[ end trace 0000000000000000 ]---


Christophe

  reply	other threads:[~2022-02-21  8:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 21:24 [PATCH v6 00/13] module: core code clean up Aaron Tomlin
2022-02-18 21:24 ` [PATCH v6 01/13] module: Move all into module/ Aaron Tomlin
2022-02-21 12:21   ` Christophe Leroy
2022-02-22 10:48     ` Aaron Tomlin
2022-02-23  1:16       ` Luis Chamberlain
2022-02-23 16:57         ` Aaron Tomlin
2022-02-21 13:13   ` Christophe Leroy
     [not found]     ` <CANfR36jccn4nHTSNOHbCz5mjaQ6r-uJONBt3taTgeX_XTEeWFw@mail.gmail.com>
2022-02-22 11:20       ` Christophe Leroy
2022-02-22 11:39         ` Aaron Tomlin
2022-02-18 21:25 ` [PATCH v6 02/13] module: Simple refactor in preparation for split Aaron Tomlin
2022-02-18 21:25 ` [PATCH v6 03/13] module: Make internal.h and decompress.c more compliant Aaron Tomlin
2022-02-18 21:25 ` [PATCH v6 04/13] module: Move livepatch support to a separate file Aaron Tomlin
2022-02-18 21:25 ` [PATCH v6 05/13] module: Move latched RB-tree " Aaron Tomlin
2022-02-21 10:57   ` Christophe Leroy
2022-02-18 21:25 ` [PATCH v6 06/13] module: Move strict rwx " Aaron Tomlin
2022-02-21  6:31   ` Christophe Leroy
2022-02-21  9:35     ` Aaron Tomlin
2022-02-21 11:27   ` Christophe Leroy
2022-02-21 16:15   ` Christophe Leroy
2022-02-18 21:25 ` [PATCH v6 07/13] module: Move extra signature support out of core code Aaron Tomlin
2022-02-18 21:25 ` [PATCH v6 08/13] module: Move kmemleak support to a separate file Aaron Tomlin
2022-02-18 21:25 ` [PATCH v6 09/13] module: Move kallsyms support into " Aaron Tomlin
2022-02-21  8:15   ` Christophe Leroy [this message]
2022-02-21  8:35     ` Christophe Leroy
2022-02-21  9:22       ` Aaron Tomlin
2022-02-22  9:58         ` Miroslav Benes
2022-02-21  9:21     ` Aaron Tomlin
2022-02-21 10:49   ` Christophe Leroy
2022-02-21 12:02     ` Aaron Tomlin
2022-02-18 21:25 ` [PATCH v6 10/13] module: Move procfs " Aaron Tomlin
2022-02-19  2:12 ` [PATCH v6 00/13] module: core code clean up Luis Chamberlain
2022-02-21 12:47   ` Miroslav Benes
2022-02-22 10:58   ` Christophe Leroy
2022-02-22 11:18   ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98cff67e-d2ca-705b-7c83-bd3f41df98d9@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=akpm@linux-foundation.org \
    --cc=allen.lkml@gmail.com \
    --cc=atomlin@atomlin.com \
    --cc=atomlin@redhat.com \
    --cc=cl@linux.com \
    --cc=ghalat@redhat.com \
    --cc=jeyu@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=msuchanek@suse.de \
    --cc=oleksandr@natalenko.name \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).