From: Masahiro Yamada <masahiroy@kernel.org>
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mcgrof@kernel.org, x86@kernel.org, hpa@zytor.com,
samitolvanen@google.com, da.gomez@samsung.com,
nathan@kernel.org, nicolas@fjasle.eu,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kbuild@vger.kernel.org, hch@infradead.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH -v2 0/7] module: Strict per-modname namespaces
Date: Sat, 8 Feb 2025 03:04:20 +0900 [thread overview]
Message-ID: <CAK7LNAQjGy+Cbt9wBsmQhn-EB8VKt_K53GJAGbk3g_qh6iorcA@mail.gmail.com> (raw)
In-Reply-To: <b35737df-01ed-46a2-ae67-e56547d6c824@suse.com>
On Wed, Feb 5, 2025 at 7:14 PM Petr Pavlu <petr.pavlu@suse.com> wrote:
>
> On 12/16/24 17:43, Petr Pavlu wrote:
> > On 12/2/24 15:59, Peter Zijlstra wrote:
> >> Hi!
> >>
> >> Implement a means for exports to be available only to an explicit list of named
> >> modules. By explicitly limiting the usage of certain exports, the abuse
> >> potential/risk is greatly reduced.
> >>
> >> The first 'patch' is an awk scripts that cleans up the existing module
> >> namespace code along the same lines of commit 33def8498fdd ("treewide: Convert
> >> macro and uses of __section(foo) to __section("foo")") and for the same reason,
> >> it is not desired for the namespace argument to be a macro expansion itself.
> >>
> >> The remainder of the patches introduce the special "MODULE_<modname-list>"
> >> namespace, which shall be forbidden from being explicitly imported. A module
> >> that matches the simple modname-list will get an implicit import.
> >
> > @Masahiro, I'd like to take this on the modules tree for 6.14. Can I get
> > an Acked-by you for the changes?
>
> Ping, this still applies mostly cleanly. I plan to take the series on
> modules-next, or let me know if you prefer for this to go through the
> kbuild tree.
I do not think this patch set is in a mature state yet.
He did not provide proper documentation or commit description.
It would be nice if he takes some time to add documentation to
Documentation/core-api/symbol-namespaces.rst
since this is a new feature of the module namespace.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2025-02-07 18:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 14:59 [PATCH -v2 0/7] module: Strict per-modname namespaces Peter Zijlstra
2024-12-02 14:59 ` [PATCH -v2 1/7] module: Convert symbol namespace to string literal Peter Zijlstra
2024-12-02 15:15 ` Peter Zijlstra
2024-12-02 15:22 ` Greg KH
2024-12-02 19:33 ` Linus Torvalds
2024-12-03 19:19 ` Mark Brown
2024-12-03 22:06 ` Mark Brown
2024-12-04 1:11 ` Masahiro Yamada
2024-12-02 14:59 ` [PATCH -v2 2/7] module/modpost: Use for() loop Peter Zijlstra
2025-02-07 8:50 ` Masahiro Yamada
2025-02-07 16:38 ` Masahiro Yamada
2024-12-02 14:59 ` [PATCH -v2 3/7] module/modpost: Add basename helper Peter Zijlstra
2025-02-07 17:56 ` Masahiro Yamada
2024-12-02 14:59 ` [PATCH -v2 4/7] module: Add module specific symbol namespace support Peter Zijlstra
2025-02-07 16:22 ` Masahiro Yamada
2024-12-02 14:59 ` [PATCH -v2 5/7] module: Extend the MODULE_ namespace parsing Peter Zijlstra
2025-02-07 8:41 ` Masahiro Yamada
2025-05-02 13:10 ` Peter Zijlstra
2025-02-07 15:45 ` Masahiro Yamada
2025-05-02 13:11 ` Peter Zijlstra
2024-12-02 14:59 ` [PATCH -v2 6/7] module: Account for the build time module name mangling Peter Zijlstra
2024-12-06 18:35 ` Sean Christopherson
2025-05-02 13:15 ` Peter Zijlstra
2024-12-02 14:59 ` [PATCH -v2 7/7] module: Provide EXPORT_SYMBOL_GPL_FOR() helper Peter Zijlstra
2025-02-07 8:09 ` Masahiro Yamada
2024-12-02 17:36 ` [PATCH -v2 0/7] module: Strict per-modname namespaces Andi Kleen
2024-12-16 16:43 ` Petr Pavlu
2025-02-05 10:14 ` Petr Pavlu
2025-02-07 18:04 ` Masahiro Yamada [this message]
2025-05-02 11:55 ` Roy, Patrick
2025-05-02 12:55 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQjGy+Cbt9wBsmQhn-EB8VKt_K53GJAGbk3g_qh6iorcA@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=da.gomez@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).