Linux Modules
 help / color / mirror / Atom feed
From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Luis Chamberlain" <mcgrof@kernel.org>, <colin.i.king@gmail.com>,
	<patches@lists.linux.dev>, <linux-modules@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <pmladek@suse.com>,
	<david@redhat.com>, <petr.pavlu@suse.com>, <prarit@redhat.com>
Cc: <christophe.leroy@csgroup.eu>, <song@kernel.org>
Subject: Re: [PATCH] stress-module: stress finit_module() and delete_module()
Date: Mon, 13 Mar 2023 16:27:53 +0100	[thread overview]
Message-ID: <CR5D0YM6E93X.S0PN49LMWT0U@vincent-arch> (raw)
In-Reply-To: <20230313103439.1235909-1-mcgrof@kernel.org>

Just some comments on the code that feel a little bit odd to me, 
while I was reading the code.

> +#if defined(HAVE_LINUX_MODULE_H)
> +#include <linux/module.h>
> +#else
> +UNEXPECTED
> +#endif
> +
> +#if defined(HAVE_LIBGEN_H)
> +#include <libgen.h>
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_MODVERSIONS
> +# define MODULE_INIT_IGNORE_MODVERSIONS 1
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_VERMAGIC
> +# define MODULE_INIT_IGNORE_VERMAGIC 2
> +#endif
looks like that the #define has an exstra space and this differ from the others 
.[c,h] files?

➜  stress-ng git:(master) ✗ git grep "#define" | wc -l
2830
➜  stress-ng git:(master) ✗ git grep "# define" | wc -l
1

Cheers!

Vincent.

      parent reply	other threads:[~2023-03-13 15:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 10:34 [PATCH] stress-module: stress finit_module() and delete_module() Luis Chamberlain
2023-03-13 12:04 ` Colin King (gmail)
2023-03-13 15:27 ` Vincenzo Palazzo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CR5D0YM6E93X.S0PN49LMWT0U@vincent-arch \
    --to=vincenzopalazzodev@gmail.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=colin.i.king@gmail.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=petr.pavlu@suse.com \
    --cc=pmladek@suse.com \
    --cc=prarit@redhat.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox