From: Luis Chamberlain <mcgrof@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Song Liu <song@kernel.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"kernel-team@meta.com" <kernel-team@meta.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] module: clean-up for module_memory
Date: Tue, 21 Feb 2023 13:15:13 -0800 [thread overview]
Message-ID: <Y/U0YfGH44dRpkXp@bombadil.infradead.org> (raw)
In-Reply-To: <a89af714-b9ee-1efa-d21d-92ffc690a7e7@csgroup.eu>
On Thu, Feb 09, 2023 at 07:43:23PM +0000, Christophe Leroy wrote:
>
>
> Le 09/02/2023 à 18:56, Song Liu a écrit :
> > Three changes here:
> >
> > 1. Shorter variable names in arch/arc/kernel/unwind.c:unwind_add_table, to
> > make it easier to read.
> > 2. Rewrite free_mod_mem() so it is more obvious that MOD_DATA need to be
> > freed last.
> > 3. Clean up the use of CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC.
> >
> > Cc: Luis Chamberlain <mcgrof@kernel.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Signed-off-by: Song Liu <song@kernel.org>
> >
> > ---
> >
> > This is the follow up patch on top of [1]. I would recommend fold this
> > into [1].
>
> With this patch folded into [1],
>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
I've squashed this into the last patch from Song and added your
Reviewed-by tag, and pushed to modules-next. That'll sit there
for a full cycle for testing.
Luis
prev parent reply other threads:[~2023-02-21 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 17:56 [PATCH] module: clean-up for module_memory Song Liu
2023-02-09 19:43 ` Christophe Leroy
2023-02-21 21:15 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/U0YfGH44dRpkXp@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=hch@lst.de \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).