From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F5EC636CC for ; Wed, 15 Feb 2023 17:23:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbjBORXW (ORCPT ); Wed, 15 Feb 2023 12:23:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbjBORXV (ORCPT ); Wed, 15 Feb 2023 12:23:21 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81FE011662 for ; Wed, 15 Feb 2023 09:23:17 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id co8so16166819wrb.1 for ; Wed, 15 Feb 2023 09:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QqtBdN+1ppp8e/CSn0vupSzwChby4224H0BfpXodQLA=; b=KUjhCHq/IyaBxJIaBshTwK5EQy/ynz7jLapyf7e2pN9XEQE1moQhCOl/Mj+qbRrfSy 3q+6cXGQF/jwUKdmo8XEUZ4a+Eho+aCAZT0nMGYMZVwCmsArr96yhUZfmXcjOqgInGRt eLPd7AuccY2D8L6b90YVy5eIQAO1JxPA82NVs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QqtBdN+1ppp8e/CSn0vupSzwChby4224H0BfpXodQLA=; b=WJ8oEcmuERCbzBqQHaBwYxR2qTZ6RQ1Fhsmpi/Mt2qHtJZ5b91m+2om4Kbl+nHBYqo YH5xg/0B0NvgCO7EwVToxlT2lOU+Ls+IWjJf8YSOCsdXFpY9t3VKL7+pjlS15lVKeQni 8Lkq+3aZJAXxYKYBdg+5Ffsa3wkPYMiDZ3HufI728Dvn/kQgb9e7CcxLSNCLm+fwjXPS NjhTOmZtJYv9Tqmz9/h/9yMS+kYInkX6OhE+jNVzmz6eELcf0GhEGbJSE0JVpCgIwIq8 NDoQtCrsPi/nLWp8QMaTdHf5vnNMRCyTZ/YspvuK8C5r69q8Wf2loVaWtIYV8n8Aiz79 CP7g== X-Gm-Message-State: AO0yUKUF7Qon8urxacuvsii5qlujaIyY5KuJpOQaJ0SdvZAhvgIH1Ax3 qu9/OLeyiHRboHZT6X/aXIVVWg== X-Google-Smtp-Source: AK7set9OHudQqPkdfMrIhN61SvMXrhUrNNXk+iAP3BJDjiL/w2O5ZVFfBlp2c3m/PeRCYgaHEFmw1w== X-Received: by 2002:adf:f30d:0:b0:2c5:4cf1:a57b with SMTP id i13-20020adff30d000000b002c54cf1a57bmr2257952wro.35.1676481795981; Wed, 15 Feb 2023 09:23:15 -0800 (PST) Received: from localhost ([2620:10d:c092:500::4:270c]) by smtp.gmail.com with ESMTPSA id n27-20020a05600c3b9b00b003e206cc7237sm1211706wms.24.2023.02.15.09.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 09:23:15 -0800 (PST) Date: Wed, 15 Feb 2023 17:23:14 +0000 From: Chris Down To: Nathan Chancellor Cc: Jiapeng Chong , mcgrof@kernel.org, ndesaulniers@google.com, trix@redhat.com, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev, Abaci Robot , Song Liu Subject: Re: [PATCH] module: Remove the unused function within Message-ID: References: <20230210064243.116335-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) Precedence: bulk List-ID: +Cc: Song Nathan Chancellor writes: >On Wed, Feb 15, 2023 at 04:47:44PM +0000, Chris Down wrote: >> Jiapeng Chong writes: >> > The function within is defined in the main.c file, but not called >> > elsewhere, so remove this unused function. >> >> Huh? It's used by __module_text_address(), no? > >Not after commit 2ece476a2346 ("module: replace module_layout with >module_memory") in -next. This patch should have a fixes tag, even if >the warning is currently hidden behind W=1. Huh, I thought I had checked out latest -next, but must have not done so somehow :-) Mea culpa. If it's only in -next then no Fixes needed, since there's no stable rev yet. Jiapeng, in future, please make sure to cc the author of related commits when reporting stuff like this :-) It helps people to update their patches. Song, you probably want to update your patch.