From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03851C43219 for ; Tue, 15 Nov 2022 07:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbiKOHa3 (ORCPT ); Tue, 15 Nov 2022 02:30:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232212AbiKOHa2 (ORCPT ); Tue, 15 Nov 2022 02:30:28 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95B5A1DDE4; Mon, 14 Nov 2022 23:30:27 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id cl5so22699554wrb.9; Mon, 14 Nov 2022 23:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=m19Xg93KjBfSnHx4juiS3V4vDkrijASgcVGL6AJsgeU=; b=jttYtcUfxSV6czckQ6I0GYNmW3+5cbKBXHuCFB3OOcpYe2tO+vVwffONsp9C73KGsi B1uo4tLV5ey3GYFBpPbd5IvV9x8t/wIdc3LqwWGhqlRm1Hzh0n+vM2LDaJ3sOew3ZVhi mRAMZ/QDj+RtF3AFwsiM7rwNzI6zcFSHBwUQZXOLgrpKjnRenRfOARWXm0kmEGLfDyv8 4pql44zHWHYqEsYWu/ICV9IXH7HGHJHpmKThrnnJFkAD0EglfujWgY2MpQqxfFom1tE6 4RP2wugeT0om3RqiOs0W3MkXS6Cm56oxL4du+j1wOERaaAYwJiw0b/jpwkJvnJ3F/NR5 g3ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m19Xg93KjBfSnHx4juiS3V4vDkrijASgcVGL6AJsgeU=; b=CgION4FMgy2lLWxt6HA8oeUyFgsc11M41Wbti+lAQ9+xpZXTfr2yJBbpGrC6HYfjwe O+Qky5yhWWDc5wceh3IYPa7lqzRGU3nsKyi9R+HHcEbzcyhEIvyzwxZEZoAKVsTroNTP WtyVSjwbKWRcKqfX2hnuUsPlKUUkjYa7U9OWZIordeNFcSnrCUJPxsSNIIOJzlSENfUA KzXHoQidPQ3+e0ezwYQTnkcXqY1qroGAG1NAwMteNfOF80MVnnmovlVK9FEdb8cGImOQ 7/UlNOnRkhzRafsecTWunh6+GviNdDeXdwSMaHRiAfUszKTWUYGAEwjq/i3h9yF4NHqL FDMA== X-Gm-Message-State: ANoB5pkOKj8qS9G0F3IBf1BlSgiYfCK05czC3nifK1Gnlpz+Utq9y3tB GfuAN+J5VfL1ralPelJQui8= X-Google-Smtp-Source: AA0mqf4lhcp6QtUhs0G1JpeMHMO0JKn1zVvg1TdYhDWJYuT7eH5wK+ILKKvZNPTuJDDUkvMXM37asA== X-Received: by 2002:a05:6000:51:b0:241:553e:5040 with SMTP id k17-20020a056000005100b00241553e5040mr9880616wrx.578.1668497426017; Mon, 14 Nov 2022 23:30:26 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id c17-20020adffb11000000b002417f35767asm8276863wrr.40.2022.11.14.23.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 23:30:25 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 15 Nov 2022 08:30:23 +0100 To: "Leizhen (ThunderTown)" Cc: Luis Chamberlain , Jiri Olsa , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Alexei Starovoitov , Kees Cook , Andrew Morton , linux-modules@vger.kernel.org, Steven Rostedt , Ingo Molnar , David Laight , Stephen Rothwell Subject: Re: [PATCH v8 7/9] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Message-ID: References: <20221102084921.1615-8-thunder.leizhen@huawei.com> <050b7513-4a20-75c7-0574-185004770329@huawei.com> <955eebae-0b36-d13f-0199-2f1b32af7da6@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Tue, Nov 15, 2022 at 10:10:16AM +0800, Leizhen (ThunderTown) wrote: > > > On 2022/11/14 23:46, Luis Chamberlain wrote: > > On Mon, Nov 14, 2022 at 02:26:19PM +0100, Jiri Olsa wrote: > >> I'll check on that, meanwhile if we could keep the module argument, > >> that'd be great > > > > As Leizhen suggested I could just drop patches: > > > > 7/9 livepatch: Improve the search performance of module_kallsyms_on_each_symbol() > > 8/9 kallsyms: Delete an unused parameter related to kallsyms_on_each_symbol() > > > > Then after the next kernel is released this can be relooked at. > > If this is agreeable let me know. > > I'm OK. sounds good, thanks jirka