From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0BC0C63703 for ; Thu, 8 Dec 2022 15:22:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbiLHPWV (ORCPT ); Thu, 8 Dec 2022 10:22:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbiLHPVf (ORCPT ); Thu, 8 Dec 2022 10:21:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC1370B81; Thu, 8 Dec 2022 07:21:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E96E61F7B; Thu, 8 Dec 2022 15:21:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54264C433C1; Thu, 8 Dec 2022 15:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670512860; bh=V4PGwpQHcRdaTj7RQB6+cCZjNiTp0CjtX/YahKcx2cI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lvJRraG+p2Y89wgqvueBx/Hwwieb06weDeQZsJjClXTuDt2c0hFVpxFdocmOreu5y 0KvQkzmvoYbdlBCPAW2JJf9QAH8ng7wTz5z+372P4f/ZleBaxJhpOQ/JjGXL28AmV9 cXCMhLD1KAJEO/CZ7uIRjtdoiUaVgJvkMTu7oesA= Date: Thu, 8 Dec 2022 16:20:56 +0100 From: Greg Kroah-Hartman To: Allen Webb Cc: Luis Chamberlain , lucas.de.marchi@gmail.com, Christophe Leroy , "linux-modules@vger.kernel.org" , "linux-usb@vger.kernel.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] modules: add modalias file to sysfs for modules. Message-ID: References: <20221129224313.455862-1-allenwebb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Thu, Dec 08, 2022 at 08:22:56AM -0600, Allen Webb wrote: > On Wed, Dec 7, 2022 at 8:34 PM Luis Chamberlain wrote: > > > > On Tue, Nov 29, 2022 at 04:43:13PM -0600, Allen Webb wrote: > > > This information is readily available for external modules in > > > modules.alias. However, builtin kernel modules are not covered. > > > > Why add this into the kernel instead of just a modules.builtin.alias > > or something like that? > > > > Luis > > I am fine with that approach and already have a PoC for it. Here are > some considerations: > * This would add a new file to the kernel packaging requirements. That's easy, you add it to the build process and the tools that pick up kernels to package them, grab everything that the build process creates. > * It is easier for separate files to get out of sync with the runtime > state (this isn't really a big deal because we already have to deal > with it for modules.alias) How can it get out of sync if it came directly from the kernel image itself? I think this really is the best solution, as it should be much simpler overall and not require every bus to add special code for it, right? thanks, greg k-h