From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF97C433F5 for ; Tue, 22 Mar 2022 05:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236558AbiCVFEZ (ORCPT ); Tue, 22 Mar 2022 01:04:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236525AbiCVFEY (ORCPT ); Tue, 22 Mar 2022 01:04:24 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15702DFB2 for ; Mon, 21 Mar 2022 22:02:57 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id q1-20020a17090a4f8100b001c6575ae105so1301246pjh.0 for ; Mon, 21 Mar 2022 22:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ceVg9Fx+CO6HpYy/wk+MDCRCh737lbvU2erecgf8G/g=; b=mxnp8aq9c8RmSTr+e6WTFt0PYgN0OUF8B3c4CHhensbiquJ9nK8CjuOGHMbLVYFBmV dKvEQ1YnCIaIq16BfUfeIlmFIy0WFGCbGlEiNv9GBwh0ov8k2HxZMRQO/Tq+f3gYL6gG c84w/F6IWvHLE+rYj88GnBfLYuRlPh3R/Ztng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ceVg9Fx+CO6HpYy/wk+MDCRCh737lbvU2erecgf8G/g=; b=24CinP2TSc4DgUXU8JfWEBe2VSy1/onLcMS7uhBhw0niRlUbU68BA1Y2BdpszLfluu rFkJjUBDfi8/APnu+1YVdFbdE5Uh6MPeGcz0OW5vWIJWhbuw+xvZ6eJeOhmPHjQRiTso X3dzItDg1c+hVMIPYqzA0DMFObSRaYRTmgsi3Ur8/KuRh5AyniaU28Z4hMPJh7L8bzbq ZkaOvdkuanSqLNqvIiZXQ9h9EOtM+vE8vHuwm33Ul67ZUcV5WJW3lXnR6MHYpWprGHRi LeXUyryemVu+W55lTcaeQLQErxiVxKQlfagjNkjYcjTCY0bw4Oa/w3yBdkF4RuYIOHAP YCYw== X-Gm-Message-State: AOAM532PkvBWwU3gY+Ze/9zGx2AEz+pbzJ0uXcPZvCExo8V9psTryXRT QbiTdIIyUTVFZPasjt0B72T1ug== X-Google-Smtp-Source: ABdhPJxqXpXz9RuKGZvf3tsV1EyeStqE29usqEUErsYJl4nqwDkw4sq6z9LM7OiX6ejjHM0sm4Zr8Q== X-Received: by 2002:a17:90b:4b4b:b0:1be:fd9a:c279 with SMTP id mi11-20020a17090b4b4b00b001befd9ac279mr2865792pjb.83.1647925376557; Mon, 21 Mar 2022 22:02:56 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:51af:6dff:4acd:7fa5]) by smtp.gmail.com with ESMTPSA id r11-20020a17090b050b00b001c741fd4890sm1058211pjz.9.2022.03.21.22.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 22:02:55 -0700 (PDT) Date: Tue, 22 Mar 2022 14:02:49 +0900 From: Sergey Senozhatsky To: Maninder Singh Cc: mcgrof@kernel.org, pmladek@suse.com, rostedt@goodmis.org, senozhatsky@chromium.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, v.narang@samsung.com, swboyd@chromium.org, ojeda@kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, avimalin@gmail.com, atomlin@redhat.com, keescook@chromium.org, ndesaulniers@google.com, rdunlap@infradead.org, void@manifault.com Subject: Re: [PATCH 1/1 module-next] kallsyms: enhance %pS/s/b printing when KALLSYSMS is disabled Message-ID: References: <20220316043540.677128-1-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220316043540.677128-1-maninder1.s@samsung.com> Precedence: bulk List-ID: On (22/03/16 10:05), Maninder Singh wrote: [..] > +static int sprint_module_info(char *buf, unsigned long value, > + int modbuildid, int backtrace, int symbol) > +{ > + struct module *mod; > + unsigned long offset; > + void *base; > + char *modname; > + int len; > + const unsigned char *buildid = NULL; > + bool add_offset; > + > + if (is_ksym_addr(value)) > + return 0; > + > + if (backtrace || symbol) > + add_offset = true; > + else > + add_offset = false; > + > + preempt_disable(); > + mod = __module_address(value); > + if (mod) { > + modname = mod->name; > +#if IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID) > + if (modbuildid) > + buildid = mod->build_id; > +#endif > + if (add_offset) { > + base = mod->core_layout.base; > + offset = value - (unsigned long)base; > + } What if address is in module init? Shouldn't this be something like if (within_module_init(value, mod)) offset = value - (unsigned long)mod->init_layout.base; else offset = value - (unsigned long)mod->core_layout.base;