From: Petr Mladek <pmladek@suse.com>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-modules@vger.kernel.org
Subject: Re: [PATCH v4 1/8] scripts/kallsyms: rename build_initial_tok_table()
Date: Wed, 21 Sep 2022 09:47:17 +0200 [thread overview]
Message-ID: <YyrBhRfiBe0tEb9d@alley> (raw)
In-Reply-To: <20220920071317.1787-2-thunder.leizhen@huawei.com>
On Tue 2022-09-20 15:13:10, Zhen Lei wrote:
> Except for the function build_initial_tok_table(), no token abbreviation
> is used elsewhere.
>
> $ cat scripts/kallsyms.c | grep tok | wc -l
> 33
> $ cat scripts/kallsyms.c | grep token | wc -l
> 31
>
> Here, it would be clearer to use the full name.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2022-09-21 7:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 7:13 [PATCH v4 0/8] kallsyms: Optimizes the performance of lookup symbols Zhen Lei
2022-09-20 7:13 ` [PATCH v4 1/8] scripts/kallsyms: rename build_initial_tok_table() Zhen Lei
2022-09-21 7:47 ` Petr Mladek [this message]
2022-09-20 7:13 ` [PATCH v4 2/8] scripts/kallsyms: ensure that all possible combinations are compressed Zhen Lei
2022-09-21 8:00 ` Petr Mladek
2022-09-21 8:31 ` Leizhen (ThunderTown)
2022-09-21 12:46 ` Leizhen (ThunderTown)
2022-09-20 7:13 ` [PATCH v4 3/8] scripts/kallsyms: don't compress symbol types Zhen Lei
2022-09-21 9:00 ` Petr Mladek
2022-09-21 13:13 ` Leizhen (ThunderTown)
2022-09-20 7:13 ` [PATCH v4 4/8] kallsyms: Improve the performance of kallsyms_lookup_name() Zhen Lei
2022-09-21 15:25 ` Petr Mladek
2022-09-22 2:15 ` Leizhen (ThunderTown)
2022-09-22 7:02 ` Petr Mladek
2022-09-22 7:21 ` Leizhen (ThunderTown)
2022-09-22 13:17 ` Petr Mladek
2022-09-28 1:35 ` Leizhen (ThunderTown)
2022-09-30 11:37 ` Leizhen (ThunderTown)
2022-09-22 7:14 ` Leizhen (ThunderTown)
2022-09-20 7:13 ` [PATCH v4 5/8] kallsyms: Add helper kallsyms_on_each_match_symbol() Zhen Lei
2022-09-21 15:30 ` Petr Mladek
2022-09-22 2:16 ` Leizhen (ThunderTown)
2022-09-20 7:13 ` [PATCH v4 6/8] livepatch: Use kallsyms_on_each_match_symbol() to improve performance Zhen Lei
2022-09-20 7:13 ` [PATCH v4 7/8] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Zhen Lei
2022-09-20 7:13 ` [PATCH v4 8/8] kallsyms: Add self-test facility Zhen Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyrBhRfiBe0tEb9d@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).