From: Luis Chamberlain <mcgrof@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>, Kees Cook <kees@kernel.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 1/3] module: Split module_enable_rodata_ro()
Date: Tue, 26 Nov 2024 11:58:02 -0800 [thread overview]
Message-ID: <Z0YoSrSNCIcvHsBl@bombadil.infradead.org> (raw)
In-Reply-To: <737f952790c96a09ad5e51689918b97ef9b29174.1731148254.git.christophe.leroy@csgroup.eu>
On Sat, Nov 09, 2024 at 11:35:35AM +0100, Christophe Leroy wrote:
> module_enable_rodata_ro() is called twice, once before module init
> to set rodata sections readonly and once after module init to set
> rodata_after_init section readonly.
>
> The second time, only the rodata_after_init section needs to be
> set to read-only, no need to re-apply it to already set rodata.
>
> Split module_enable_rodata_ro() in two.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Didn't see a respin so this will have to be a post v6.13-rc1 fix.
Luis
next prev parent reply other threads:[~2024-11-26 19:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241109103551eucas1p1bddb2f2d9a898aba967868dece7cd685@eucas1p1.samsung.com>
2024-11-09 10:35 ` [RFC PATCH 1/3] module: Split module_enable_rodata_ro() Christophe Leroy
2024-11-09 10:35 ` [RFC PATCH 2/3] module: Don't fail module loading when setting ro_after_init section RO failed Christophe Leroy
2024-11-09 22:17 ` Daniel Gomez
2024-11-11 18:53 ` Christophe Leroy
2024-11-12 9:43 ` Daniel Gomez
2024-11-12 11:08 ` Christophe Leroy
2024-11-12 14:35 ` Petr Pavlu
2024-11-28 20:23 ` Daniel Gomez
2024-12-04 15:14 ` Petr Pavlu
2024-12-10 10:49 ` Daniel Gomez
2024-12-11 8:46 ` Daniel Gomez
2025-01-03 15:40 ` Petr Pavlu
2025-01-04 7:42 ` Christophe Leroy
2024-11-11 17:05 ` Petr Pavlu
2024-11-09 10:35 ` [RFC PATCH 3/3] module: pre-test setting ro_after_init data read-only Christophe Leroy
2024-11-09 21:03 ` Daniel Gomez
2024-11-11 18:55 ` Christophe Leroy
2024-11-12 20:28 ` Luis Chamberlain
2024-11-13 6:49 ` Christophe Leroy
2024-11-13 9:56 ` Luis Chamberlain
2024-11-09 22:18 ` [RFC PATCH 1/3] module: Split module_enable_rodata_ro() Daniel Gomez
2024-11-26 19:58 ` Luis Chamberlain [this message]
2024-11-27 13:37 ` Christophe Leroy
2024-11-27 18:55 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0YoSrSNCIcvHsBl@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=da.gomez@samsung.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).