From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D8FC761A6 for ; Mon, 20 Mar 2023 21:24:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230169AbjCTVYX (ORCPT ); Mon, 20 Mar 2023 17:24:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbjCTVYL (ORCPT ); Mon, 20 Mar 2023 17:24:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A529135ED1; Mon, 20 Mar 2023 14:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/kDlpw47TTHOQh497IMH/PT4qyEkoNDw64tv3lyuGnU=; b=woGMX5dBRZBBV8tFoNvea9nz7e mff3T8449NYWkL5S1yakwaew7bKRtPwTyJJML2uL3vszsaE44pvV79UrccNvdKvTZcHRg3xktBkpI GabeN4KG+XAbomkvHR44nhWKott9ul1larreRgyrmAbkpHARz/KbSxpALnAzAoZzzLZqg9NnbKc5S xSTywbx2lcQbfgLlgmyiAF63RFL1caPLWMQPkygJycb+39pO1HzYKtE6tptJLL51kMThNvfzk21mW PXuGW4e/KUKGDCc8uGOvhMMcYoqBysNQs+eqfhsEMUBGNR4X/BTd5NzSeFkXMPOXoIcs6vh+yasiW hhg8a4uA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1peMye-00AWpb-31; Mon, 20 Mar 2023 21:23:36 +0000 Date: Mon, 20 Mar 2023 14:23:36 -0700 From: Luis Chamberlain To: David Hildenbrand , Adam Manzanares Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, christophe.leroy@csgroup.eu, song@kernel.org, torvalds@linux-foundation.org Subject: Re: [RFC 00/12] module: avoid userspace pressure on unwanted allocations Message-ID: References: <3b25ed5c-8fb9-82d3-2296-fadbbb4db7e4@redhat.com> <2bd995a7-5b7f-59a1-751e-c56e76a7d592@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: On Mon, Mar 20, 2023 at 10:15:23PM +0100, David Hildenbrand wrote: > On 20.03.23 22:09, Luis Chamberlain wrote: > > On Mon, Mar 20, 2023 at 08:40:07PM +0100, David Hildenbrand wrote: > > > On 20.03.23 10:38, David Hildenbrand wrote: > > > > On 18.03.23 01:11, Luis Chamberlain wrote: > > > > > On Thu, Mar 16, 2023 at 04:56:56PM -0700, Luis Chamberlain wrote: > > > > > > On Thu, Mar 16, 2023 at 04:55:31PM -0700, Luis Chamberlain wrote: > > > > > > > On Wed, Mar 15, 2023 at 05:41:53PM +0100, David Hildenbrand wrote: > > > > > > > > I expect to have a machine (with a crazy number of CPUs/devices) available > > > > > > > > in a couple of days (1-2), so no need to rush. > > > > > > > > > > > > > > > > The original machine I was able to reproduce with is blocked for a little > > > > > > > > bit longer; so I hope the alternative I looked up will similarly trigger the > > > > > > > > issue easily. > > > > > > > > > > > > > > OK give this a spin: > > > > > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230316-module-alloc-opts > > > > > > > > > > Today I am up to here: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230317-module-alloc-opts > > > > > > > > > > The last patch really would have no justification yet at all unless it > > > > > does help your case. > > > > > > > > Still waiting on the system (the replacement system I was able to grab > > > > broke ...). > > > > > > > > I'll let you know once I succeeded in reproducing + testing your fixes. > > > > > > Okay, I have a system where I can reproduce. > > > > > > Should I give > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230319-module-alloc-opts > > > > > > from yesterday a churn? > > > > Yes please give that a run. > > Reproduced with v6.3.0-rc1 (on 1st try) By reproduced, you mean it fails to boot? > Not able to reproduce with 20230319-module-alloc-opts so far (2 tries). Oh wow, so to clarify, it boots OK? > > Please collect systemd-analyze given lack of any other tool to evaluate > > any deltas. Can't think of anything else to gather other than seeing if > > it booted. > > Issue is that some services (kdump, tuned) seem to take sometimes ages on > that system to start for some reason, How about disabling that? > and systemd-analyze refuses to do > something reasonable while the system is still booting up. I see. > I'll see if I can come up with some data. Thanks! > > If that boots works then try removing the last patch "module: add a > > sanity check prior to allowing kernel module auto-loading" to see if > > that last patch helped or was just noise. As it stands I'm not convinced > > yet if it did help, if it *does* help we probably need to rethink some > > finit_module() allocations things. > > Okay, will try without the last patch tomorrow. Thanks!! Luis