* Re: [PATCH] Use CRC32 and a 1MiB dictionary for XZ compressed modules
[not found] <3d34a965-ab9c-d549-0c63-c717ab5d2edc@tweek.dk>
@ 2023-09-22 9:16 ` Nicolas Schier
0 siblings, 0 replies; only message in thread
From: Nicolas Schier @ 2023-09-22 9:16 UTC (permalink / raw)
To: Martin Nybo Andersen
Cc: Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Nick Terrell, Nicolas Schier, linux-kbuild, linux-kernel,
linux-modules
In linux-modules@v.k.o probably some more experts can comment on this:
On Fri, Sep 15, 2023 at 12:15:39PM +0200, Martin Nybo Andersen wrote:
> Kmod is now using the kernel decompressor which doesn't handle CRC64
> and dictionaries larger than 1MiB.
>
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050582
> Signed-off-by: Martin Nybo Andersen <tweek@tweek.dk>
> ---
> scripts/Makefile.modinst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index c59cc57286ba..ffbafbd3aeea 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -144,7 +144,7 @@ endif
> quiet_cmd_gzip = GZIP $@
> cmd_gzip = $(KGZIP) -n -f $<
> quiet_cmd_xz = XZ $@
> - cmd_xz = $(XZ) --lzma2=dict=2MiB -f $<
> + cmd_xz = $(XZ) --check=crc32 --lzma2=dict=1MiB -f $<
> quiet_cmd_zstd = ZSTD $@
> cmd_zstd = $(ZSTD) -T0 --rm -f -q $<
>
> --
> 2.40.1
^ permalink raw reply [flat|nested] only message in thread