linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Kris Van Hees <kris.van.hees@oracle.com>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-modules@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	Nick Alcock <nick.alcock@oracle.com>,
	Alan Maguire <alan.maguire@oracle.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Jiri Olsa <olsajiri@gmail.com>,
	Elena Zannoni <elena.zannoni@oracle.com>
Subject: Re: [PATCH v5 3/4] scripts: add verifier script for builtin module range data
Date: Wed, 14 Aug 2024 21:02:52 -0400	[thread overview]
Message-ID: <Zr1TvFAu56dd+u8j@oracle.com> (raw)
In-Reply-To: <20240814161606.1b514882@gandalf.local.home>

On Wed, Aug 14, 2024 at 04:16:06PM -0400, Steven Rostedt wrote:
> On Wed, 14 Aug 2024 15:59:58 -0400
> Kris Van Hees <kris.van.hees@oracle.com> wrote:
> 
> > > What does this mean?  
> > 
> > Hm, this is certainly why the validation script exists.  I am surprised, though
> > not entirely because kernel changes toward the 6.10 branching and such came
> > after I create this version.  Would you be willing to send me a copy of your
> > .config for this kernel build so I can investigate?  This output is typical
> > of a case where the script was not able to determine offse ranges correctly.
> 
> Attached.

So, looking back at your output it seems that the problem is that I did not
make it obvious that the verifier script is written to be executed from the
root of the kernel build tree, i.e. where the objects are stored.  I'll add
support for an optional extra argument to the script so that a path to the
actual object tree can be provided.  That was an important oversight on my
part - sorry about that.

So, if your kernel is built into an object directory, the script in its
current state would need to be executed with that object directory as current
working directory.

I.e. if the build directory is /work/build/nobackup/debiantesting-x86-64/ and
the kernel source tree is in /work/source/linux, change CWD to that build
directory and invoke the verifier as:

/work/source/linux/scripts/verify_builtin_ranges.awk modules.builtin.ranges System.map modules.builtin vmlinux.map vmlinux.o.map

Can you try that and verify that the output is correct in that case?  I expect
it will be.

v6 of the series (which I hope to post tomorrow) will allow you to specify
the path to the object tree so that this will be more user friendly.

	Kris

  reply	other threads:[~2024-08-15  1:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16  3:10 [PATCH v5 0/4] Generate address range data for built-in modules Kris Van Hees
2024-07-16  3:10 ` [PATCH v5 1/4] kbuild: add mod(name,file)_flags to assembler flags for module objects Kris Van Hees
2024-08-14 17:17   ` Steven Rostedt
2024-08-14 19:42     ` Kris Van Hees
2024-07-16  3:10 ` [PATCH v5 2/4] kbuild, kconfig: generate offset range data for builtin modules Kris Van Hees
2024-08-14 19:04   ` Steven Rostedt
2024-08-14 19:52     ` Kris Van Hees
2024-07-16  3:10 ` [PATCH v5 3/4] scripts: add verifier script for builtin module range data Kris Van Hees
2024-08-14 19:19   ` Steven Rostedt
2024-08-14 19:59     ` Kris Van Hees
2024-08-14 20:16       ` Steven Rostedt
2024-08-15  1:02         ` Kris Van Hees [this message]
2024-07-16  3:10 ` [PATCH v5 4/4] module: add install target for modules.builtin.ranges Kris Van Hees
2024-08-14 16:45 ` [PATCH v5 0/4] Generate address range data for built-in modules Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zr1TvFAu56dd+u8j@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=alan.maguire@oracle.com \
    --cc=elena.zannoni@oracle.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nick.alcock@oracle.com \
    --cc=olsajiri@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).